Issue 6598091: Bitmap generator for components files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6598091: Bitmap generator for components files (Closed)

Created:
9 years, 9 months ago by Nick Sanders

Modified:
9 years, 7 months ago

Reviewers:
yongjaek, Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Bitmap generator for components files BUG=chrome-os-partner:2558 TEST=some files are generated Change-Id: I6a69bce20d626e9a273711db099d7ec5c3b08686 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e328d56

Patch Set 3 : cl feedback #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -1 line)			Patch
	M	scripts/newbitmaps/HWID.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	scripts/newbitmaps/make_bmp_from_components.py	View	1 2	1 chunk	+86 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

One problem. http://codereview.chromium.org/6598091/diff/2001/scripts/newbitmaps/make_bmp_from_components.py File scripts/newbitmaps/make_bmp_from_components.py (right): http://codereview.chromium.org/6598091/diff/2001/scripts/newbitmaps/make_bmp_from_components.py#newcode40 scripts/newbitmaps/make_bmp_from_components.py:40: os.system("cat %s | sed 's/hwid_unknown.bmp/hwid.bmp/' > %s" ...

9 years, 9 months ago (2011-03-02 18:49:38 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 6598091: Bitmap generator for components files (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : cl feedback #

Messages