Issue 6598066: Port eval resolve in call optimization from classic to full codegen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6598066: Port eval resolve in call optimization from classic to full codegen. (Closed)

Created:
9 years, 9 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Port eval resolve in call optimization from classic to full codegen.

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -43 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	2 chunks	+46 lines, -17 lines	1 comment	Download
M	src/full-codegen.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	2 chunks	+43 lines, -13 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+43 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 9 months ago (2011-03-01 15:13:22 UTC) #2

LGTM

http://codereview.chromium.org/6598066/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6598066/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:2376: __ ldr(r1,
Looks like this would fit on one line?

Expand Messages | Collapse Messages