Add stuff to support new bitmap format.

Add stuff to support new bitmap format.

Add bitmap_viewer program (to run OUTSIDE of chroot) and example bitmaps (to
be replaced by the REAL bitmaps for each platform).

BUG=chromium-os:10949
TEST=none

These are just nonessential tools and examples. No regression testing needed.

Change-Id: I7f9aab30809251e4c62d71bfa73293d0b4d97196

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=dfe4ca5

[Randall Spangler, 2011-03-01 17:37:18]

A few suggestions

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/bmpbl...
File scripts/newbitmaps/lib/bmpblock.py (right):

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/bmpbl...
scripts/newbitmaps/lib/bmpblock.py:29: # FIXME: this is pretty lame
# FIXME: lame that we need to chdir to the same dir as the file?

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/bmpbl...
scripts/newbitmaps/lib/bmpblock.py:56: assert type(val) == str and len(val) > 0
assert val and type(val) == str

(since an empty string evaluates as false)

Or to handle unicode and things that subclass string,

val and isinstance(val, types.StringTypes)

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/bmpbl...
scripts/newbitmaps/lib/bmpblock.py:60: assert len(screens) > 0
Can just assert screens, since empty dict evaluates to false

(similarly in other places below)

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/bmpbl...
scripts/newbitmaps/lib/bmpblock.py:72: assert isinstance(localizations, (list,
tuple))
Slightly more pythonic way of seeing if something is iterable:

hasattr(localizations,'__iter__')

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/bmpbl...
scripts/newbitmaps/lib/bmpblock.py:84: # TODO: should these be fatal?
It'll still work if there are unused images; just wastes space, right?  I'd say
just warn.

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/pixco...
File scripts/newbitmaps/lib/pixcontrol.py (right):

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/pixco...
scripts/newbitmaps/lib/pixcontrol.py:35: 
Extra newline

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/pixco...
scripts/newbitmaps/lib/pixcontrol.py:83: """I may have picked one of the
pulldowns."""
I -> User

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/pixdi...
File scripts/newbitmaps/lib/pixdisplay.py (right):

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/pixdi...
scripts/newbitmaps/lib/pixdisplay.py:23: done_first = False
Might want to comment that size is taken from the first image in the list / see
spec.

http://codereview.chromium.org/6598046/diff/7007/scripts/newbitmaps/lib/pixdi...
scripts/newbitmaps/lib/pixdisplay.py:46: # HEY: really?
Leftover comment? (line 51 too)

[Bill Richardson, 2011-03-01 18:48:09]

Thanks.

[Randall Spangler, 2011-03-01 19:23:32]

LGTM with one more fix

http://codereview.chromium.org/6598046/diff/1066/scripts/newbitmaps/lib/bmpbl...
File scripts/newbitmaps/lib/bmpblock.py (right):

http://codereview.chromium.org/6598046/diff/1066/scripts/newbitmaps/lib/bmpbl...
scripts/newbitmaps/lib/bmpblock.py:58: assert val and isinstance(val,
types.StringTypes) and len(val) > 0
don't need 'and len' now