Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 6598041: Merge remote branch 'autotest-upstream/master' into merge-upstream (Closed)

Created:
9 years, 9 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
thieule
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Merge remote branch 'autotest-upstream/master' into merge-upstream rev 5270 and 5271. BUG=None TEST=Run BVT test. Change-Id: I46ee56cea4861d9dd35b98f0a21536122714518c [PATCH] After_iteration hooks are not executed if test fails. Base_test's _call_run_once() does not execute the after_iteration hooks if the test fails. It is important to execute the after_iteration hooks in the event of a test failure since these hooks may be used to gather important test logs to help diagnose the failure. This patch modifies _call_run_once() to execute after_iteration hooks regardless of the outcome of the test. A new unit test was added to verify the behavior of _call_run_once(). The patch was tested using unittest_suite.py to ensure that it did not break other functionalities. It was also tested with an actual after_iteration hook that collected test logs and the test was forced to fail. Risk: High Visibility: The order of when the after_iteration hooks has been changed and may affect existing tests. Bugs: None Signed-off-by: Thieu Le <thieule@chromium.org>; git-svn-id: svn://test.kernel.org/autotest/trunk@5271 592f7852-d20e-0410-864c-8624ca9c26a4 KVM test: Make unattended setup copy finish.exe to floppies Fixing yet another bug from the conversion of unattended install to infrastructure. Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=daf6ff0

Patch Set 1 #

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M client/common_lib/test.py View 1 chunk +18 lines, -15 lines 0 comments Download
M client/common_lib/test_unittest.py View 1 chunk +23 lines, -1 line 0 comments Download
M client/tests/kvm/test_setup.py View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ericli
9 years, 9 months ago (2011-02-28 18:59:05 UTC) #1
thieule
9 years, 9 months ago (2011-03-01 23:10:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698