Strict mode - allow function only in SourceElements.

Strict mode - allow function only in SourceElements.


BUG=
TEST=test/mjsunit/strict-mode.js

[Martin Maly, 2011-02-26 19:50:01]

Syntax error if function is in the block in strict mode.
Only as part of SourceElements it is allowed.

[Mads Ager (chromium), 2011-02-28 08:30:12]

LGTM

http://codereview.chromium.org/6598023/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/6598023/diff/1/src/messages.js#newcode229
src/messages.js:229: strict_function:              ["In strict mode code,
functions can only be declared at top level or immediately within another
function." ],
Seems like a very long (but informative) error message. The language here is
very different from the other error messages. Can we use the same style:
"Function declaration in local scope disallowed in strict mode" or something
like that?

http://codereview.chromium.org/6598023/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/6598023/diff/1/src/parser.cc#newcode1111
src/parser.cc:1111: if (peek() == Token::FUNCTION) {
You should add a comment here as well to make it clear why this parse statement
call is treated specially.

[Martin Maly, 2011-02-28 18:57:33]

Applied the CR feedback. thanks!

Martin

http://codereview.chromium.org/6598023/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/6598023/diff/1/src/messages.js#newcode229
src/messages.js:229: strict_function:              ["In strict mode code,
functions can only be declared at top level or immediately within another
function." ],
On 2011/02/28 08:30:12, Mads Ager wrote:
> Seems like a very long (but informative) error message. The language here is
> very different from the other error messages. Can we use the same style:
> "Function declaration in local scope disallowed in strict mode" or something
> like that?

Done.

http://codereview.chromium.org/6598023/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/6598023/diff/1/src/parser.cc#newcode1111
src/parser.cc:1111: if (peek() == Token::FUNCTION) {
On 2011/02/28 08:30:12, Mads Ager wrote:
> You should add a comment here as well to make it clear why this parse
statement
> call is treated specially. 

Done.