Adding break iterator support to the i18n api extension....

src/extensions/experimental/i18n-extension.cc

Index: src/extensions/experimental/i18n-extension.cc
===================================================================
--- src/extensions/experimental/i18n-extension.cc	(revision 6955)
+++ src/extensions/experimental/i18n-extension.cc	(working copy)
@@ -30,6 +30,7 @@
 #include <algorithm>
 #include <string>
 
+#include "break-iterator.h"
 #include "unicode/locid.h"
 #include "unicode/uloc.h"
 
@@ -87,6 +88,26 @@
   "  var displayLocale = this.displayLocale_(optDisplayLocale);"
   "  native function NativeJSDisplayName();"
   "  return NativeJSDisplayName(this.locale, displayLocale);"
+  "};"
+  "v8Locale.v8BreakIterator = function(locale, type) {"

[Mads Ager (chromium), 2011/03/01 09:10:14]

Do you need to have the v8 prefix on everything in here? I would guess that
having a V8 prefix on the v8Locale object is enough. You cannot get to any of
this without going through that which makes it clear that this is v8 specific.

I would remove the v8 prefix from v8BreakIterator and from v8CreateBreakIterator
(which would be consistent with using names like displayName instead of
v8DisplayName for other methods).

[Nebojša Ćirić, 2011/03/01 17:15:15]

I'll rename v8Locale into LocaleInfo soon so we'll lose the vendor branding
there.

BreakIterator is different from other methods under Locale object because it's
not part of the current EcmaScript proposal and I want to keep all vendor
specific methods/object under v8 prefix for now.

So for now we have ugly(?) v8Locale.v8BreakIterator, but as soon as I rename
v8Locale we will have only LocaleInfo.v8BreakIterator.

On 2011/03/01 09:10:14, Mads Ager wrote:

+  "  native function NativeJSBreakIterator();"
+  "  if (locale === undefined || type === undefined) {"
+  "    throw new Error('Locale and iterator type are required.');"
+  "  }"
+  "  var iterator = NativeJSBreakIterator(locale, type);"
+  "  iterator.type = type;"
+  "  return iterator;"
+  "};"
+  "v8Locale.v8BreakIterator.BreakType = {"
+  "  'unknown': -1,"
+  "  'none': 0,"
+  "  'number': 100,"
+  "  'word': 200,"
+  "  'kana': 300,"
+  "  'ideo': 400"
+  "};"
+  "v8Locale.prototype.v8CreateBreakIterator = function(type) {"
+  "  return new v8Locale.v8BreakIterator(this.locale, type);"
   "};";
 
 v8::Handle<v8::FunctionTemplate> I18NExtension::GetNativeFunction(
@@ -107,6 +128,8 @@
     return v8::FunctionTemplate::New(JSDisplayRegion);
   } else if (name->Equals(v8::String::New("NativeJSDisplayName"))) {
     return v8::FunctionTemplate::New(JSDisplayName);
+  } else if (name->Equals(v8::String::New("NativeJSBreakIterator"))) {
+    return v8::FunctionTemplate::New(BreakIterator::JSBreakIterator);
   }
 
   return v8::Handle<v8::FunctionTemplate>();