Adding break iterator support to the i18n api extension....

src/extensions/experimental/i18n-extension.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 12 matching lines @@
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "i18n-extension.h"
 
 #include <algorithm>
 #include <string>
 
+#include "break-iterator.h"
 #include "unicode/locid.h"
 #include "unicode/uloc.h"
 
 namespace v8 {
 namespace internal {
 
 I18NExtension* I18NExtension::extension_ = NULL;
 
 // TODO(cira): maybe move JS code to a .js file and generata cc files from it?
 // TODO(cira): Remove v8 prefix from v8Locale once we have stable API.
@@ skipping 37 matching lines @@
   "};"
   "v8Locale.prototype.displayRegion = function(optDisplayLocale) {"
   "  var displayLocale = this.displayLocale_(optDisplayLocale);"
   "  native function NativeJSDisplayRegion();"
   "  return NativeJSDisplayRegion(this.locale, displayLocale);"
   "};"
   "v8Locale.prototype.displayName = function(optDisplayLocale) {"
   "  var displayLocale = this.displayLocale_(optDisplayLocale);"
   "  native function NativeJSDisplayName();"
   "  return NativeJSDisplayName(this.locale, displayLocale);"
+  "};"
+  "v8Locale.v8BreakIterator = function(locale, type) {"

[Mads Ager (chromium), 2011/03/01 09:10:14]

Do you need to have the v8 prefix on everything in here? I would guess that
having a V8 prefix on the v8Locale object is enough. You cannot get to any of
this without going through that which makes it clear that this is v8 specific.

I would remove the v8 prefix from v8BreakIterator and from v8CreateBreakIterator
(which would be consistent with using names like displayName instead of
v8DisplayName for other methods).

[Nebojša Ćirić, 2011/03/01 17:15:15]

I'll rename v8Locale into LocaleInfo soon so we'll lose the vendor branding
there.

BreakIterator is different from other methods under Locale object because it's
not part of the current EcmaScript proposal and I want to keep all vendor
specific methods/object under v8 prefix for now.

So for now we have ugly(?) v8Locale.v8BreakIterator, but as soon as I rename
v8Locale we will have only LocaleInfo.v8BreakIterator.

On 2011/03/01 09:10:14, Mads Ager wrote:

+  "  native function NativeJSBreakIterator();"
+  "  if (locale === undefined || type === undefined) {"
+  "    throw new Error('Locale and iterator type are required.');"
+  "  }"
+  "  var iterator = NativeJSBreakIterator(locale, type);"
+  "  iterator.type = type;"
+  "  return iterator;"
+  "};"
+  "v8Locale.v8BreakIterator.BreakType = {"
+  "  'unknown': -1,"
+  "  'none': 0,"
+  "  'number': 100,"
+  "  'word': 200,"
+  "  'kana': 300,"
+  "  'ideo': 400"
+  "};"
+  "v8Locale.prototype.v8CreateBreakIterator = function(type) {"
+  "  return new v8Locale.v8BreakIterator(this.locale, type);"
   "};";
 
 v8::Handle<v8::FunctionTemplate> I18NExtension::GetNativeFunction(
     v8::Handle<v8::String> name) {
   if (name->Equals(v8::String::New("NativeJSLocale"))) {
     return v8::FunctionTemplate::New(JSLocale);
   } else if (name->Equals(v8::String::New("NativeJSAvailableLocales"))) {
     return v8::FunctionTemplate::New(JSAvailableLocales);
   } else if (name->Equals(v8::String::New("NativeJSMaximizedLocale"))) {
     return v8::FunctionTemplate::New(JSMaximizedLocale);
   } else if (name->Equals(v8::String::New("NativeJSMinimizedLocale"))) {
     return v8::FunctionTemplate::New(JSMinimizedLocale);
   } else if (name->Equals(v8::String::New("NativeJSDisplayLanguage"))) {
     return v8::FunctionTemplate::New(JSDisplayLanguage);
   } else if (name->Equals(v8::String::New("NativeJSDisplayScript"))) {
     return v8::FunctionTemplate::New(JSDisplayScript);
   } else if (name->Equals(v8::String::New("NativeJSDisplayRegion"))) {
     return v8::FunctionTemplate::New(JSDisplayRegion);
   } else if (name->Equals(v8::String::New("NativeJSDisplayName"))) {
     return v8::FunctionTemplate::New(JSDisplayName);
+  } else if (name->Equals(v8::String::New("NativeJSBreakIterator"))) {
+    return v8::FunctionTemplate::New(BreakIterator::JSBreakIterator);
   }
 
   return v8::Handle<v8::FunctionTemplate>();
 }
 
 v8::Handle<v8::Value> I18NExtension::JSLocale(const v8::Arguments& args) {
   // TODO(cira): Fetch browser locale. Accept en-US as good default for now.
   // We could possibly pass browser locale as a parameter in the constructor.
   std::string locale_name("en-US");
   if (args.Length() == 1 && args[0]->IsString()) {
@@ skipping 135 matching lines @@
     extension_ = new I18NExtension();
   }
   return extension_;
 }
 
 void I18NExtension::Register() {
   static v8::DeclareExtension i18n_extension_declaration(I18NExtension::get());
 }
 
 } }  // namespace v8::internal