Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 6598009: Deprecating tracked_directories as a Vault parameter (Closed)

Created:
9 years, 10 months ago by glotov
Modified:
9 years, 7 months ago
Reviewers:
fes
CC:
chromium-os-reviews_chromium.org, Chris Masone, gauravsh, Will Drewry, Nikita (slow)
Visibility:
Public.

Description

Deprecating tracked_directories as a Vault parameter in favor of managing them internally in Cryptohomed Change-Id: I66b1db4a69e64c826b3316ba7ac2705ae12e2872 BUG=chromium-os:9620 TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cc7d912

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -211 lines) Patch
M cryptohome.cc View 6 chunks +4 lines, -31 lines 0 comments Download
M cryptohome.xml View 2 chunks +4 lines, -4 lines 0 comments Download
M make_tests.h View 1 chunk +0 lines, -1 line 0 comments Download
M make_tests.cc View 2 chunks +14 lines, -19 lines 0 comments Download
M mount.h View 2 chunks +1 line, -27 lines 0 comments Download
M mount.cc View 3 chunks +1 line, -43 lines 0 comments Download
M mount_unittest.cc View 2 chunks +6 lines, -67 lines 0 comments Download
M service.h View 1 chunk +4 lines, -4 lines 2 comments Download
M service.cc View 4 chunks +4 lines, -14 lines 0 comments Download
M vault_keyset.proto View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
glotov
Hi Frank! This is a cleanup change and there are mostly deletions. Please have a ...
9 years, 10 months ago (2011-02-25 19:28:26 UTC) #1
fes
Minor style nit. Otherwise, as long as this passed FEATURES=test and bvt, it LGTM. http://codereview.chromium.org/6598009/diff/1/service.h ...
9 years, 10 months ago (2011-02-25 23:08:41 UTC) #2
glotov
9 years, 9 months ago (2011-02-28 18:22:33 UTC) #3
Committing tomorrow.
Unittests and bvt autotest pass:

INFO   : Test results:
-------------------------------------------------------
suites.bvt                                        PASS
suites.bvt/build_RootFilesystemSize               PASS
  bytes_rootfs_prod                               593661952.0
  bytes_rootfs_test                               593756160.0
suites.bvt/desktopui_ChromeFirstRender            PASS
  seconds_chrome_first_tab                        4.27
suites.bvt/desktopui_FlashSanityCheck             PASS
suites.bvt/desktopui_KillRestart.chrome           PASS
suites.bvt/desktopui_KillRestart.session          PASS
suites.bvt/desktopui_WindowManagerFocusNewWindows PASS
suites.bvt/graphics_WindowManagerGraphicsCapture  PASS
suites.bvt/logging_CrashSender                    PASS
suites.bvt/logging_UserCrash                      PASS
suites.bvt/login_BadAuthentication                PASS
suites.bvt/login_CryptohomeIncognitoMounted       PASS
suites.bvt/login_CryptohomeMounted                PASS
suites.bvt/login_LoginSuccess.apps                PASS
suites.bvt/login_LoginSuccess.default             PASS
suites.bvt/login_RemoteLogin                      PASS
suites.bvt/network_DisableInterface.wlan0         PASS
suites.bvt/network_Ping                           PASS
suites.bvt/platform_AccurateTime                  PASS
  seconds_offset                                  0.0
suites.bvt/platform_FilePerms                     PASS
suites.bvt/platform_HighResTimers                 PASS
suites.bvt/platform_KernelVersion                 PASS
suites.bvt/platform_OSLimits                      PASS
suites.bvt/platform_PartitionCheck                PASS
suites.bvt/platform_Shutdown                      PASS
  seconds_shutdown                                0.39
  sectors_read_shutdown                           448.0
  sectors_written_shutdown                        0.0
suites.bvt/power_Resume                           PASS
  seconds_system_resume                           0.999669075012
  seconds_system_resume_firmware                  0.503317075012
  seconds_system_resume_kernel                    0.496352
  seconds_system_suspend                          0.728117
-------------------------------------------------------
Total PASS: 26/26 (100%)

No crashes detected during testing.
Elapsed time: 11m11s

http://codereview.chromium.org/6598009/diff/1/service.h
File service.h (right):

http://codereview.chromium.org/6598009/diff/1/service.h#newcode114
service.h:114: gboolean deprecated_replace_tracked_subdirectories,
On 2011/02/25 23:08:41, fes wrote:
> 80 Columns

Done.

Powered by Google App Engine
This is Rietveld 408576698