Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/extensions/extension_event_router_forwarder.cc

Issue 6598002: Make the ChromeNetworkDelegate use the ExtensionEventRouterForwarder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_event_router_forwarder.cc
diff --git a/chrome/browser/extensions/extension_event_router_forwarder.cc b/chrome/browser/extensions/extension_event_router_forwarder.cc
index b0189081ce1192a7a6372947f0c639b0e9dd22b5..3b0b2d4d593997b7a8ad5c0205e7e4f8ed339e87 100644
--- a/chrome/browser/extensions/extension_event_router_forwarder.cc
+++ b/chrome/browser/extensions/extension_event_router_forwarder.cc
@@ -6,7 +6,6 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_event_router.h"
-#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "googleurl/src/gurl.h"
@@ -19,15 +18,16 @@ ExtensionEventRouterForwarder::~ExtensionEventRouterForwarder() {
void ExtensionEventRouterForwarder::BroadcastEventToRenderers(
const std::string& event_name, const std::string& event_args,
const GURL& event_url) {
- HandleEvent("", event_name, event_args, NULL, true, event_url);
+ HandleEvent("", event_name, event_args, 0, true, event_url);
}
void ExtensionEventRouterForwarder::DispatchEventToRenderers(
const std::string& event_name, const std::string& event_args,
- Profile* profile, bool use_profile_to_restrict_events,
+ ProfileId profile_id, bool use_profile_to_restrict_events,
const GURL& event_url) {
- DCHECK(profile);
- HandleEvent("", event_name, event_args, profile,
+ if (profile_id == Profile::kInvalidProfileId)
+ return;
+ HandleEvent("", event_name, event_args, profile_id,
use_profile_to_restrict_events, event_url);
}
@@ -35,23 +35,24 @@ void ExtensionEventRouterForwarder::BroadcastEventToExtension(
const std::string& extension_id,
const std::string& event_name, const std::string& event_args,
const GURL& event_url) {
- HandleEvent(extension_id, event_name, event_args, NULL, true, event_url);
+ HandleEvent(extension_id, event_name, event_args, 0, true, event_url);
}
void ExtensionEventRouterForwarder::DispatchEventToExtension(
const std::string& extension_id,
const std::string& event_name, const std::string& event_args,
- Profile* profile, bool use_profile_to_restrict_events,
+ ProfileId profile_id, bool use_profile_to_restrict_events,
const GURL& event_url) {
- DCHECK(profile);
- HandleEvent(extension_id, event_name, event_args, profile,
+ if (profile_id == Profile::kInvalidProfileId)
+ return;
+ HandleEvent(extension_id, event_name, event_args, profile_id,
use_profile_to_restrict_events, event_url);
}
void ExtensionEventRouterForwarder::HandleEvent(
const std::string& extension_id,
const std::string& event_name, const std::string& event_args,
- Profile* profile, bool use_profile_to_restrict_events,
+ ProfileId profile_id, bool use_profile_to_restrict_events,
const GURL& event_url) {
if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
BrowserThread::PostTask(
@@ -59,7 +60,7 @@ void ExtensionEventRouterForwarder::HandleEvent(
NewRunnableMethod(
this,
&ExtensionEventRouterForwarder::HandleEvent,
- extension_id, event_name, event_args, profile,
+ extension_id, event_name, event_args, profile_id,
use_profile_to_restrict_events, event_url));
return;
}
@@ -68,9 +69,13 @@ void ExtensionEventRouterForwarder::HandleEvent(
return;
ProfileManager* profile_manager = g_browser_process->profile_manager();
- if (profile) {
- if (!profile_manager->IsValidProfile(profile))
+ Profile* profile = NULL;
+ if (profile_id != Profile::kInvalidProfileId) {
+ profile = profile_manager->GetProfileWithId(profile_id);
+ if (!profile)
return;
+ }
+ if (profile) {
CallExtensionEventRouter(
profile, extension_id, event_name, event_args,
use_profile_to_restrict_events ? profile : NULL, event_url);

Powered by Google App Engine
This is Rietveld 408576698