Make the ChromeNetworkDelegate use the ExtensionEventRouterForwarder

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/ref_counted.h"
 #include "base/scoped_ptr.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "net/base/cookie_monster.h"
 
 class CommandLine;
 class ChromeAppCacheService;
 class ChromeBlobStorageContext;
 class ChromeURLRequestContext;
 class ChromeURLRequestContextGetter;
 class ExtensionInfoMap;
-class ExtensionIOEventRouter;
 namespace fileapi {
 class FileSystemContext;
 }
 class HostContentSettingsMap;
 class HostZoomMap;
 class IOThread;
 namespace net {
 class DnsCertProvenanceChecker;
 class NetLog;
 class ProxyConfigService;
@@ skipping 63 matching lines @@
     scoped_refptr<HostContentSettingsMap> host_content_settings_map;
     scoped_refptr<HostZoomMap> host_zoom_map;
     scoped_refptr<net::TransportSecurityState> transport_security_state;
     scoped_refptr<net::SSLConfigService> ssl_config_service;
     scoped_refptr<net::CookieMonster::Delegate> cookie_monster_delegate;
     scoped_refptr<webkit_database::DatabaseTracker> database_tracker;
     scoped_refptr<ChromeAppCacheService> appcache_service;
     scoped_refptr<ChromeBlobStorageContext> blob_storage_context;
     scoped_refptr<fileapi::FileSystemContext> file_system_context;
     scoped_refptr<ExtensionInfoMap> extension_info_map;
-    scoped_refptr<ExtensionIOEventRouter> extension_io_event_router;
     scoped_refptr<prerender::PrerenderManager> prerender_manager;
     scoped_refptr<ProtocolHandlerRegistry> protocol_handler_registry;
     // We need to initialize the ProxyConfigService from the UI thread
     // because on linux it relies on initializing things through gconf,
     // and needs to be on the main thread.
     scoped_ptr<net::ProxyConfigService> proxy_config_service;
+    // The profile this struct was populated from. We must not dereference
+    // this pointer on any but the UI thread with prior checking that it is
+    // still valid, e.g. using ProfileManager::IsValidProfile.
+    Profile* profile;

[willchan no longer on Chromium, 2011/02/26 02:11:35]

jochen, I think I told you this was ok before, but I am concerned about this
Profile*, especially since it's stored in ChromeNetworkDelegate where you don't
have a comment like this. Also, people never read comments. I think there's
probably something we could do where the global event forwarder could maintain a
mapping of Profile*<=>Foo, where Foo can be passed in ProfileParams and used by
the ChromeNetworkDelegate when calling back into the event forwarder.

I'm curious what ericroman thinks here. I suspect he shares my concern with
exposing the Profile* on the IO thread. 

   };
 
   explicit ProfileIOData(bool is_off_the_record);
   virtual ~ProfileIOData();
 
   // Static helper functions to assist in common operations executed by
   // subtypes.
 
   static void InitializeProfileParams(Profile* profile, ProfileParams* params);
   static void ApplyProfileParamsToContext(const ProfileParams& profile_params,
@@ skipping 27 matching lines @@
       AcquireMediaRequestContext() const = 0;
   virtual scoped_refptr<ChromeURLRequestContext>
       AcquireExtensionsRequestContext() const = 0;
 
   mutable bool initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_