FilePath: add a convertor to ASCII

base/file_path.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // FilePath is a container for pathnames stored in a platform's native string
 // type, providing containers for manipulation in according with the
 // platform's conventions for pathnames.  It supports the following path
 // types:
 //
 //                   POSIX            Windows
@@ skipping 265 matching lines @@
   // Returns true if this FilePath contains any attempt to reference a parent
   // directory (i.e. has a path component that is ".."
   bool ReferencesParent() const;
 
   // Return a Unicode human-readable version of this path.
   // Warning: you can *not*, in general, go from a display name back to a real
   // path.  Only use this when displaying paths to users, not just when you
   // want to stuff a string16 into some other API.
   string16 LossyDisplayName() const;
 
+  // Return the path as ASCII, or the empty string if the path is not ASCII.
+  // This should only be used for cases where the FilePath is representing a
+  // known-ASCII filename.
+  std::string MaybeAsASCII() const;

[Avi (use Gerrit), 2011/03/01 19:56:36]

method name FTW

+
   // Older Chromium code assumes that paths are always wstrings.
   // These functions convert wstrings to/from FilePaths, and are
   // useful to smooth porting that old code to the FilePath API.
   // They have "Hack" in their names so people feel bad about using them.
   // http://code.google.com/p/chromium/issues/detail?id=24672
   //
   // If you are trying to be a good citizen and remove these, ask yourself:
   // - Am I interacting with other Chrome code that deals with files?  Then
   //   try to convert the API into using FilePath.
   // - Am I interacting with OS-native calls?  Then use value() to get at an
@@ skipping 95 matching lines @@
 namespace stdext {
 
 inline size_t hash_value(const FilePath& f) {
   return hash_value(f.value());
 }
 
 }  // namespace stdext
 #endif  // COMPILER
 
 #endif  // BASE_FILE_PATH_H_