Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: net/proxy/polling_proxy_config_service.h

Issue 6597070: Allow ProxyConfigService to report "no configuration set" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comment Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/polling_proxy_config_service.h
diff --git a/net/proxy/polling_proxy_config_service.h b/net/proxy/polling_proxy_config_service.h
index b4295ec10344d69f776b4eb4a4e405c1f5eca221..dd65ac2fd3ff82fea8e57c64c880f92da193632b 100644
--- a/net/proxy/polling_proxy_config_service.h
+++ b/net/proxy/polling_proxy_config_service.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,8 +6,8 @@
#define NET_PROXY_POLLING_PROXY_CONFIG_SERVICE_H_
#pragma once
-#include "base/time.h"
#include "base/ref_counted.h"
+#include "base/time.h"
#include "net/proxy/proxy_config_service.h"
namespace net {
@@ -22,14 +22,15 @@ class PollingProxyConfigService : public ProxyConfigService {
// ProxyConfigService implementation:
virtual void AddObserver(Observer* observer);
virtual void RemoveObserver(Observer* observer);
- virtual bool GetLatestProxyConfig(ProxyConfig* config);
+ virtual ConfigAvailability GetLatestProxyConfig(ProxyConfig* config);
virtual void OnLazyPoll();
protected:
// Function for retrieving the current proxy configuration.
// Implementors must be threadsafe as the function will be invoked from
// worker threads.
- typedef void (*GetConfigFunction)(ProxyConfig*);
+ typedef ProxyConfigService::ConfigAvailability
eroman 2011/03/16 01:30:00 I don't think we should change this. We don't supp
Mattias Nissler (ping if slow) 2011/03/16 17:40:00 Done.
+ (*GetConfigFunction)(ProxyConfig*);
// Creates a polling-based ProxyConfigService which will test for new
// settings at most every |poll_interval| time by calling |get_config_func|

Powered by Google App Engine
This is Rietveld 408576698