Allow ProxyConfigService to report "no configuration set"

net/proxy/proxy_config_service.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_CONFIG_SERVICE_H_
 #define NET_PROXY_PROXY_CONFIG_SERVICE_H_
 #pragma once
 
 namespace net {
 
 class ProxyConfig;
 
 // Service for watching when the proxy settings have changed.
 class ProxyConfigService {
  public:
+  // Indicates whether proxy configuration is valid, and if not, why.
+  enum ConfigAvailability {
+    // Configuration is pending, observers will be notified later.
+    CONFIG_PENDING,
+    // Configuration is present and valid.
+    CONFIG_VALID,
+    // No configuration is set, use default.

[eroman, 2011/03/16 01:30:00]

nit: I suggest removing the "use default" comment (it is up to the caller to
decide what they want to do).

[Mattias Nissler (ping if slow), 2011/03/16 17:40:00]

Done.

+    CONFIG_UNSET
+  };
+
   // Observer for being notified when the proxy settings have changed.
   class Observer {
    public:
     virtual ~Observer() {}
-    virtual void OnProxyConfigChanged(const ProxyConfig& config) = 0;
+    virtual void OnProxyConfigChanged(const ProxyConfig& config,

[eroman, 2011/03/16 01:30:00]

Could you add a comment explaining that |availability| will NEVER be
CONFIG_PENDING here.

And moreover, that |config| is only interesting when availability ==
CONFIG_VALID.

[Mattias Nissler (ping if slow), 2011/03/16 17:40:00]

Done.

+                                      ConfigAvailability availability) = 0;
   };
 
   virtual ~ProxyConfigService() {}
 
   // Adds/Removes an observer that will be called whenever the proxy
   // configuration has changed.
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
   // Gets the most recent value of the proxy configuration. Returns false if

[eroman, 2011/03/16 01:30:00]

Please update these comments regarding the return value.

[Mattias Nissler (ping if slow), 2011/03/16 17:40:00]

Absolutely! Sorry for missing it.
Done.

[eroman, 2011/03/26 00:50:30]

I don't see this change in the latest pathset...

   // it is not available yet. In the case where we returned false, it is
   // guaranteed that subscribed observers will be notified of a change at
   // some point in the future once the configuration is available.
   // Note that to avoid re-entrancy problems, implementations should not
   // dispatch any change notifications from within this function.
-  virtual bool GetLatestProxyConfig(ProxyConfig* config) = 0;
+  virtual ConfigAvailability GetLatestProxyConfig(ProxyConfig* config) = 0;
 
   // ProxyService will call this periodically during periods of activity.
   // It can be used as a signal for polling-based implementations.
   //
   // Note that this is purely used as an optimization -- polling
   // implementations could simply set a global timer that goes off every
   // X seconds at which point they check for changes. However that has
   // the disadvantage of doing continuous work even during idle periods.
   virtual void OnLazyPoll() {}
 };
 
 }  // namespace net
 
 #endif  // NET_PROXY_PROXY_CONFIG_SERVICE_H_