Issue 6597062: Fix icu header paths in autofill_country.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6597062: Fix icu header paths in autofill_country.cc (Closed)

Created:
9 years, 9 months ago by Mike Gilbert

Modified:
9 years, 7 months ago

Reviewers:
Ilya Sherman, Paweł Hajdan Jr.

CC:
chromium-reviews, James Hawkins, dhollowa

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Fix icu header paths in autofill_country.cc Fixes build problem when building with system ICU. See Gentoo Linux bug. http://bugs.gentoo.org/356593 BUG=74286 TEST=Remove bundled ICU headers and build with -Duse_system_icu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76360

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/autofill/autofill_country.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

Mike Gilbert

I did a build with the bundled ICU as well as a system ICU (via ...

9 years, 9 months ago (2011-03-01 03:08:13 UTC) #1

Ilya Sherman

nit: Please rearrange these #include lines to be in alphabetical order.

9 years, 9 months ago (2011-03-01 03:12:11 UTC) #2

Ilya Sherman

9 years, 9 months ago (2011-03-01 03:59:11 UTC) #4

LGTM, thanks!

Will run this past the trybots and commit if there are no problems.