Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 6597045: Do not allow non-configurable global properties to be made configurable (fixe... (Closed)

Created:
9 years, 9 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not allow non-configurable global properties to be made configurable (fixes issue 1213). We do not currently check that a global property is actually configurable before overwriting it with a new property. Committed: http://code.google.com/p/v8/source/detail?r=6978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M src/runtime.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-1213.js View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 9 months ago (2011-02-28 19:05:38 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-01 08:04:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698