Issue 6597011: Add NV storage fields for firmware flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6597011: Add NV storage fields for firmware flags (Closed)

Created:
9 years, 10 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Add NV storage fields for firmware flags 1) Did firmware attempt RW slot B before slot A? 2) Did firmware check the kernel keyblock signature, or just its hash? Added crossystem support as well. BUG=chrome-os-partner:1657 TEST=make && make runtests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1726028

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed tried_fwb #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -69 lines)			Patch
M	firmware/include/vboot_nvstorage.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	firmware/lib/vboot_nvstorage.c	View		3 chunks	+34 lines, -6 lines	0 comments	Download
M	host/lib/crossystem.c	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
M	tests/vboot_nvstorage_test.c	View		4 chunks	+37 lines, -63 lines	0 comments	Download
M	utility/crossystem_main.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Richardson

LGTM, with one question. http://codereview.chromium.org/6597011/diff/1/host/lib/crossystem.c File host/lib/crossystem.c (right): http://codereview.chromium.org/6597011/diff/1/host/lib/crossystem.c#newcode488 host/lib/crossystem.c:488: else if (!strcasecmp(name,"fwb_try_used")) { Why ...

9 years, 10 months ago (2011-02-25 19:18:31 UTC) #2

Randall Spangler

9 years, 10 months ago (2011-02-25 19:22:04 UTC) #3

http://codereview.chromium.org/6597011/diff/1/host/lib/crossystem.c
File host/lib/crossystem.c (right):

http://codereview.chromium.org/6597011/diff/1/host/lib/crossystem.c#newcode488
host/lib/crossystem.c:488: else if (!strcasecmp(name,"fwb_try_used")) {
On 2011/02/25 19:18:31, Bill Richardson wrote:
> Why do we call the parameter "b_try_used" instead of "used_try_b" or
> "try_b_used" ?
> 
> B or not B, there is no try.
> 

How about tried_fwb

Expand Messages | Collapse Messages