Issue 6597005: Properly account the thread index on all exit paths from the function. Preven...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6597005: Properly account the thread index on all exit paths from the function. Preven... (Closed)

Created:
9 years, 10 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Cris Neckar, scherkus (not reviewing)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/ffmpeg/

Visibility:
Public.

Properly account the thread index on all exit paths from the function. Prevents a crash with certain mp4 files. BUG=73026 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76138

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -2 lines)			Patch
M	README.chromium	View	2 chunks	+9 lines, -0 lines	0 comments	Download
A	patches/to_upstream/23_thread_index.patch	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	source/patched-ffmpeg-mt/libavcodec/pthread.c	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Cris Neckar

LGTM but hopefully scherkus can sanity check it On 2011/02/25 12:38:12, Chris Evans wrote:

9 years, 10 months ago (2011-02-26 00:41:45 UTC) #2

LGTM