Issue 6596093: Add some bullet proofing to ipc_channel_posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6596093: Add some bullet proofing to ipc_channel_posix. (Closed)

Created:
9 years, 9 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
dmaclach1, jeremy

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/ipc

Visibility:
Public.

Description

Add some bullet proofing to ipc_channel_posix. Specifically make sure you can't connect after creating a bad channel. BUG=NONE TEST=Build and run tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76633

Patch Set 1 #

Patch Set 2 : Fix up accidental overwrites #

Patch Set 3 : replace NOTREACHED with LOG(ERROR) #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -19 lines)			Patch
M	ipc/ipc_channel_posix.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	1 2	4 chunks	+21 lines, -18 lines	1 comment	Download
M	ipc/ipc_channel_posix_unittest.cc	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeremy

LGTM with changing LOG(ERROR) to NOTREACHED() http://codereview.chromium.org/6596093/diff/3001/ipc/ipc_channel_posix.cc File ipc/ipc_channel_posix.cc (right): http://codereview.chromium.org/6596093/diff/3001/ipc/ipc_channel_posix.cc#newcode405 ipc/ipc_channel_posix.cc:405: LOG(ERROR) << "Bad ...

9 years, 9 months ago (2011-03-02 19:05:45 UTC) #2

dmaclach1

9 years, 9 months ago (2011-03-02 20:09:02 UTC) #3

On Wed, Mar 2, 2011 at 11:05 AM,  <jeremy@chromium.org> wrote:
> LGTM with changing LOG(ERROR) to NOTREACHED()
>
>
> http://codereview.chromium.org/6596093/diff/3001/ipc/ipc_channel_posix.cc
> File ipc/ipc_channel_posix.cc (right):
>
>
http://codereview.chromium.org/6596093/diff/3001/ipc/ipc_channel_posix.cc#new...
> ipc/ipc_channel_posix.cc:405: LOG(ERROR) << "Bad mode: " << mode_;
> Why did you changed the NOTREACHED()'s to LOG(ERROR)?
> Why not do:
> NOTREACHED() << "bla" ?

because there is a mode (MODE_NONE) that could let you get into that
state accidentally. So NOTREACHED is really not appropriate.

>
> http://codereview.chromium.org/6596093/
>

Expand Messages | Collapse Messages