Don't allow multiple opens for Pepper FileSystem.

ppapi/proxy/ppb_file_system_proxy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppb_file_system_proxy.h"
 
 #include "base/message_loop.h"
 #include "base/task.h"
 #include "ppapi/c/dev/ppb_file_system_dev.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 10 matching lines @@
 // querying. It's all set in the constructor from the "create info" sent from
 // the host.
 class FileSystem : public PluginResource {
  public:
   FileSystem(const HostResource& host_resource, PP_FileSystemType_Dev type);
   virtual ~FileSystem();
 
   virtual FileSystem* AsFileSystem();
 
   PP_FileSystemType_Dev type_;
-  bool opened_;
+  bool called_open_;
   PP_CompletionCallback current_open_callback_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FileSystem);
 };
 
 FileSystem::FileSystem(const HostResource& host_resource,
                        PP_FileSystemType_Dev type)
     : PluginResource(host_resource),
       type_(type),
-      opened_(false),
+      called_open_(false),
       current_open_callback_(PP_MakeCompletionCallback(NULL, NULL)) {
 }
 
 // TODO(brettw) this logic is duplicated with some other resource objects
 // like FileChooser. It would be nice to look at all of the different resources
 // that need callback tracking and design something that they can all re-use.
 FileSystem::~FileSystem() {
   // Ensure the callback is always fired.
   if (current_open_callback_.func) {
     // TODO(brettw) the callbacks at this level should be refactored with a
@@ skipping 29 matching lines @@
   FileSystem* object = PluginResource::GetAs<FileSystem>(resource);
   return BoolToPPBool(!!object);
 }
 
 int32_t Open(PP_Resource file_system,
              int64_t expected_size,
              struct PP_CompletionCallback callback) {
   FileSystem* object = PluginResource::GetAs<FileSystem>(file_system);
   if (!object)
     return PP_ERROR_BADRESOURCE;
-  if (object->opened_)
-    return PP_OK;
 
   Dispatcher* dispatcher = PluginDispatcher::GetForInstance(object->instance());
   if (!dispatcher)
     return PP_ERROR_BADARGUMENT;
 
   if (object->current_open_callback_.func)
     return PP_ERROR_INPROGRESS;
+  else if (object->called_open_)
+    return PP_ERROR_FAILED;
+
   object->current_open_callback_ = callback;
+  object->called_open_ = true;
 
   dispatcher->Send(new PpapiHostMsg_PPBFileSystem_Open(
       INTERFACE_ID_PPB_FILE_SYSTEM, object->host_resource(), expected_size));
   return PP_ERROR_WOULDBLOCK;
 }
 
 PP_FileSystemType_Dev GetType(PP_Resource resource) {
   FileSystem* object = PluginResource::GetAs<FileSystem>(resource);
   if (!object)
     return PP_FILESYSTEMTYPE_INVALID;
@@ skipping 83 matching lines @@
 
 void PPB_FileSystem_Proxy::OpenCompleteInHost(
     int32_t result,
     const HostResource& host_resource) {
   dispatcher()->Send(new PpapiMsg_PPBFileSystem_OpenComplete(
       INTERFACE_ID_PPB_FILE_SYSTEM, host_resource, result));
 }
 
 }  // namespace proxy
 }  // namespace pp