Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: remoting/protocol/host_stub.h

Issue 6594138: Block event processing on host/client until the client has authenticated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mock objects for unittests Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/host_stub.h
diff --git a/remoting/protocol/host_stub.h b/remoting/protocol/host_stub.h
index 1a26225847e40e83772421d1198639bbcaf9f123..866b4671e94a2d2355fe98c7630043bbff1192f8 100644
--- a/remoting/protocol/host_stub.h
+++ b/remoting/protocol/host_stub.h
@@ -4,7 +4,7 @@
// Interface of a host that receives commands from a Chromoting client.
//
-// This interterface handles control messages defined in contro.proto.
+// This interface handles control messages defined in contro.proto.
#ifndef REMOTING_PROTOCOL_HOST_STUB_H_
#define REMOTING_PROTOCOL_HOST_STUB_H_
@@ -21,7 +21,7 @@ class LocalLoginCredentials;
class HostStub {
public:
- HostStub() {}
+ HostStub() : enable_(false) {}
virtual ~HostStub() {};
dmac 2011/03/04 01:36:27 since this is no longer pure virtual, move out of
garykac 2011/03/04 05:33:24 Done.
virtual void SuggestResolution(
@@ -29,7 +29,26 @@ class HostStub {
virtual void BeginSessionRequest(
const LocalLoginCredentials* credentials, Task* done) = 0;
+ // Enable the client->host control channel.
+ // This should be set to true only after a trusted communication channel has
+ // been established.
+ // When this is false, only a limited set of control messages will be
+ // processed.
+ void SetEnable(bool enable) {
dmac 2011/03/04 01:36:27 actually the var name should probably be enabled,
garykac 2011/03/04 05:33:24 Done.
+ enable_ = enable;
+ }
+
+ // Is the control channel enabled?
+ // I.e., should we be processing control events?
+ bool Enabled() {
+ return enable_;
+ }
+
private:
+ // Initially false, this controls whether the control events received from the
+ // client should be processed.
+ bool enable_;
+
DISALLOW_COPY_AND_ASSIGN(HostStub);
};

Powered by Google App Engine
This is Rietveld 408576698