Block event processing on host/client until the client has authenticated.

remoting/protocol/client_stub.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Interface of a client that receives commands from a Chromoting host.
 //
 // This interface is responsible for a subset of control messages sent to
 // the Chromoting client.
 
 #ifndef REMOTING_PROTOCOL_CLIENT_STUB_H_
 #define REMOTING_PROTOCOL_CLIENT_STUB_H_
 
 #include "base/basictypes.h"
 
 class Task;
 
 namespace remoting {
 namespace protocol {
 
 class LocalLoginStatus;
 class NotifyResolutionRequest;
 
 class ClientStub {
  public:
-  ClientStub() {}
-  virtual ~ClientStub() {}
+  ClientStub();

[Wez, 2011/03/04 12:09:38]

Is there a more descriptive name we can attached to this, and make it more
uniform with the related Input and Video classes? e.g. ClientControl,
ClientInput, ClientVideo

[garykac, 2011/03/04 20:28:02]

I agree that it would be nice to have better names, but I'll defer that to a
separate CL.

+  virtual ~ClientStub();
 
   virtual void NotifyResolution(const NotifyResolutionRequest* msg,
                                 Task* done) = 0;
   virtual void BeginSessionResponse(const LocalLoginStatus* msg,
                                     Task* done) = 0;
 
+  // Enable the host->client control channel.
+  // This should be set to true only after a trusted communication channel has
+  // been established.
+  // When this is false, only a limited set of control messages will be
+  // processed.
+  void SetEnabled(bool enabled);
+

[Wez, 2011/03/04 12:09:38]

Move from SetEnabled(bool) to OnAuthenticated()?

[garykac, 2011/03/04 20:28:02]

Done.

+  // Is the control channel enabled?
+  // I.e., should we be processing control events?
+  bool enabled();

[Wez, 2011/03/04 12:09:38]

Do we need this?

[garykac, 2011/03/04 20:28:02]

The message dispatchers make use of this to cut off processing the input or
control packets.  These dispatchers don't currently have access to the
connection_to_host/client, so it's convenient to have it here.

+
  private:
+  // Initially false, this controls whether the control events received from
+  // the host should be processed.
+  bool enabled_;
+
   DISALLOW_COPY_AND_ASSIGN(ClientStub);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CLIENT_STUB_H_