Block event processing on host/client until the client has authenticated.

remoting/client/input_handler.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/input_handler.h"
 
 #include "remoting/client/chromoting_view.h"
 #include "remoting/proto/event.pb.h"
 #include "remoting/protocol/connection_to_host.h"
 
 namespace remoting {
 
 using protocol::KeyEvent;
 using protocol::MouseEvent;
 
 InputHandler::InputHandler(ClientContext* context,
                            protocol::ConnectionToHost* connection,
                            ChromotingView* view)
     : context_(context),
       connection_(connection),
       view_(view) {
 }
 
 void InputHandler::SendKeyEvent(bool press, int keycode) {
   protocol::InputStub* stub = connection_->input_stub();
-  if (stub) {
+  if (stub && stub->enabled()) {

[Wez, 2011/03/04 12:09:38]

Why does the InputStub and/or InputHandler even exist if we haven't yet
authenticated?

[garykac, 2011/03/04 20:28:02]

On host side: input_stub if part of the DesktopEnvironment owned by
ChromotingHost so it would be awkward to create it after authentication.

On client side: I now delay creation until authentication.

We still need |enabled| for the host, but I removed the check here.

     KeyEvent* event = new KeyEvent();
     event->set_keycode(keycode);
     event->set_pressed(press);
 
     stub->InjectKeyEvent(event, new DeleteTask<KeyEvent>(event));
   }
 }
 
 void InputHandler::SendMouseMoveEvent(int x, int y) {
   protocol::InputStub* stub = connection_->input_stub();
-  if (stub) {
+  if (stub && stub->enabled()) {
     MouseEvent* event = new MouseEvent();
     event->set_x(x);
     event->set_y(y);
 
     stub->InjectMouseEvent(event, new DeleteTask<MouseEvent>(event));
   }
 }
 
 void InputHandler::SendMouseButtonEvent(bool button_down,
                                         MouseEvent::MouseButton button) {
   protocol::InputStub* stub = connection_->input_stub();
-  if (stub) {
+  if (stub && stub->enabled()) {
     MouseEvent* event = new MouseEvent();
     event->set_button(button);
     event->set_button_down(button_down);
 
     stub->InjectMouseEvent(event, new DeleteTask<MouseEvent>(event));
   }
 }
 
 }  // namespace remoting