Issue 6594132: cros_workon: start process of removing cros_workon from src/scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6594132: cros_workon: start process of removing cros_workon from src/scripts (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
robotboy, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

cros_workon: start process of removing cros_workon from src/scripts All tools have been modified to use /usr/bin/cros_workon. So we can start removing from src/scripts. For now, print an error so users aren't caught off guard. In a couple of weeks, I'll remove from src/scripts. BUG=11507 TEST=none Change-Id: Ia5f9996bc54fd97b1264cddcf4a0f945fbcb01b4 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=efba42e

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -269 lines)			Patch
	M	cros_workon	View		1 chunk	+1 line, -269 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

9 years, 9 months ago (2011-03-03 00:32:19 UTC) #2

LGTM with optional nit. Can we say run "cros_workon" instead of
"./cros_workon" in the error message?
On Mar 2, 2011 2:45 PM, <msb@chromium.org> wrote:
> Reviewers: anush, robotboy,
>
> Description:
> cros_workon: start process of removing cros_workon from src/scripts
>
> All tools have been modified to use /usr/bin/cros_workon. So we can
> start removing from src/scripts.
>
> For now, print an error so users aren't caught off guard. In a couple
> of weeks, I'll remove from src/scripts.
>
> BUG=11507
> TEST=none
>
> Change-Id: Ia5f9996bc54fd97b1264cddcf4a0f945fbcb01b4
>
> Please review this at http://codereview.chromium.org/6594132/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
> M cros_workon
>
>

Expand Messages | Collapse Messages