Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 6594131: Add support for using separate developer firmware keyblock while signing. (Closed)

Created:
9 years, 9 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add support for using separate developer firmware keyblock while signing. Also re-factor the key generation script to its own directory, including wrappers for generating key pairs and keyblocks without needing to start keyset generation process from scratch. (Useful for generating new kernel keyblocks, and for retroactively adding new keys to an existing keyset - as in this case). Finally, change hard coded algorithm ids and keyblock modes to bash variables, for each changes and telling keyset configuration from a glance. BUG=chrome-os-partner:2218 TEST=manually tried the following: 1) Generating an entire new keyset. 2) Generating a new key pair and creating a keyblock from an existing key (for generating dev firmware keyblock for existing PVT keysets) 3) Firmware signing via sign_official_build.sh of an image with a firmware payload/ Change-Id: I4e9bb96ac7e5fe4cc0d95af6162ad6d37bbd4bda Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5746845

Patch Set 1 #

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -135 lines) Patch
M scripts/image_signing/resign_firmwarefd.sh View 1 4 chunks +11 lines, -8 lines 0 comments Download
M scripts/image_signing/sign_official_build.sh View 1 chunk +2 lines, -0 lines 0 comments Download
A scripts/keygeneration/common.sh View 1 chunk +92 lines, -0 lines 0 comments Download
A scripts/keygeneration/create_new_keys.sh View 1 chunk +65 lines, -0 lines 0 comments Download
A scripts/keygeneration/make_keyblock.sh View 1 chunk +27 lines, -0 lines 0 comments Download
A scripts/keygeneration/make_pair.sh View 1 chunk +23 lines, -0 lines 0 comments Download
D tests/devkeys/create_new_keys.sh View 1 chunk +0 lines, -127 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
9 years, 9 months ago (2011-03-02 22:16:55 UTC) #1
Randall Spangler
9 years, 9 months ago (2011-03-02 22:27:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698