Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: printing/image.cc

Issue 6594121: Revert 76553 - Applying factory pattern (through NativeMetafileFactory class)... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « printing/emf_win_unittest.cc ('k') | printing/native_metafile.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "printing/image.h" 5 #include "printing/image.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/md5.h" 8 #include "base/md5.h"
9 #include "base/scoped_ptr.h"
10 #include "base/string_number_conversions.h" 9 #include "base/string_number_conversions.h"
11 #include "printing/native_metafile_factory.h"
12 #include "third_party/skia/include/core/SkColor.h" 10 #include "third_party/skia/include/core/SkColor.h"
13 #include "ui/gfx/codec/png_codec.h" 11 #include "ui/gfx/codec/png_codec.h"
14 12
15 namespace printing { 13 namespace printing {
16 14
17 Image::Image(const FilePath& path) 15 Image::Image(const FilePath& path)
18 : row_length_(0), 16 : row_length_(0),
19 ignore_alpha_(true) { 17 ignore_alpha_(true) {
20 std::string data; 18 std::string data;
21 file_util::ReadFileToString(path, &data); 19 file_util::ReadFileToString(path, &data);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 bool success = gfx::PNGCodec::Decode( 137 bool success = gfx::PNGCodec::Decode(
140 reinterpret_cast<const unsigned char*>(compressed.c_str()), 138 reinterpret_cast<const unsigned char*>(compressed.c_str()),
141 compressed.size(), gfx::PNGCodec::FORMAT_BGRA, &data_, &w, &h); 139 compressed.size(), gfx::PNGCodec::FORMAT_BGRA, &data_, &w, &h);
142 size_.SetSize(w, h); 140 size_.SetSize(w, h);
143 row_length_ = size_.width() * sizeof(uint32); 141 row_length_ = size_.width() * sizeof(uint32);
144 return success; 142 return success;
145 } 143 }
146 144
147 bool Image::LoadMetafile(const std::string& data) { 145 bool Image::LoadMetafile(const std::string& data) {
148 DCHECK(!data.empty()); 146 DCHECK(!data.empty());
149 scoped_ptr<NativeMetafile> metafile( 147 NativeMetafile metafile;
150 printing::NativeMetafileFactory::CreateMetafile()); 148 metafile.Init(data.data(), data.size());
151 metafile->Init(data.data(), data.size()); 149 return LoadMetafile(metafile);
152 return LoadMetafile(*metafile);
153 } 150 }
154 151
155 } // namespace printing 152 } // namespace printing
OLDNEW
« no previous file with comments | « printing/emf_win_unittest.cc ('k') | printing/native_metafile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698