Issue 6594118: Add ArithmeticD(MOD) to x64 optimizing code generator. Minor changes to Arit...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6594118: Add ArithmeticD(MOD) to x64 optimizing code generator. Minor changes to Arit... (Closed)

Created:
9 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add ArithmeticD(MOD) to x64 optimizing code generator. Minor changes to ArithmeticD on other platforms. Committed: http://code.google.com/p/v8/source/detail?r=7029

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -37 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+11 lines, -10 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	2 chunks	+7 lines, -14 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+14 lines, -8 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

Function DoArithmeticD is not reached with op = Token::MOD. The LArithmeticD object with op = ...

9 years, 9 months ago (2011-03-02 14:00:19 UTC) #1

LGTM