src/x64/deoptimizer-x64.cc - Issue 6594115: Optimize loads from root-array in X64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/deoptimizer-x64.cc

Issue 6594115: Optimize loads from root-array in X64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Reordered the root-array slightly. Should have no effect on ia32, but help slightly on x64. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/deoptimizer-x64.cc

diff --git a/src/x64/deoptimizer-x64.cc b/src/x64/deoptimizer-x64.cc

index 1a84a5711a86012a333160f2e2ca0ccd415d7bd6..daa912806d4cfd0579e2ba48c4df78e66f3d4b37 100644

--- a/src/x64/deoptimizer-x64.cc

+++ b/src/x64/deoptimizer-x64.cc

@@ -749,11 +749,8 @@ void Deoptimizer::EntryGenerator::Generate() {

// Set up the roots register.

ExternalReference roots_address = ExternalReference::roots_address();

- __ movq(r13, roots_address);

- __ movq(kSmiConstantRegister,

- reinterpret_cast<uint64_t>(Smi::FromInt(kSmiConstantRegisterValue)),

- RelocInfo::NONE);

+ __ InitializeRootRegister();

+ __ InitializeSmiConstantRegister();

// Return to the continuation point.

__ ret(0);

« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »