saft: update 'flashrom_util' to use new syntax

saft: update 'flashrom_util' to use new syntax

Using 'iotools' to control flashrom target is obsoleted.
The new parameter provided by 'flashrom' utility is better and prevents potential
race condition, so all scripts using flashrom should apply the new syntax.

BUG=chromium-os:11339
TEST=passed SAFT on CR48 (by josephsih)

Change-Id: Ia5f7d7ea3bc087b4506a101407a21087b4e278b7

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b25ef92

[vb, 2011-03-02 17:50:08]

LGTM in general,

with a comment below and a few nits:

In the cl description, please include reference to a document describing
flashrom command line options (I hope one exists :P).

Do we need need to worry about the case when SAFT running on a platform with
older flashrom?

http://codereview.chromium.org/6594114/diff/1/saft_flashrom_util.py
File saft_flashrom_util.py (right):

http://codereview.chromium.org/6594114/diff/1/saft_flashrom_util.py#newcode226
saft_flashrom_util.py:226: self._target_command = '-p internal:bus=spi'
why not to make it 'flashrom -p internal:bus=spi' - just a thought.

[Hung-Te, 2011-03-03 06:52:29]

On 2011/03/02 17:50:08, vb wrote:
> In the cl description, please include reference to a document describing
> flashrom command line options (I hope one exists :P).
   Unfortunately no. Upstream flashrom does not support such command,
   and that's only in chromiumos branch, without manual...

> Do we need need to worry about the case when SAFT running on a platform with
> older flashrom?
   No, because this was supported long long ago, for more than three months (or
even half a year).

http://codereview.chromium.org/6594114/diff/1/saft_flashrom_util.py
File saft_flashrom_util.py (right):

http://codereview.chromium.org/6594114/diff/1/saft_flashrom_util.py#newcode226
saft_flashrom_util.py:226: self._target_command = '-p internal:bus=spi'
On 2011/03/02 17:50:08, vb wrote:
> why not to make it 'flashrom -p internal:bus=spi' - just a thought.
 Because I'm not sure if SAFT will need to deal with EC in the future, so trying
to keep max flexibility here.