Issue 6594107: Add PPB_URLUtil_Dev::GetDocumentURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6594107: Add PPB_URLUtil_Dev::GetDocumentURL (Closed)

Created:
9 years, 9 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add PPB_URLUtil_Dev::GetDocumentURL This also renames "Url" into "URL" for consistency. BUG=74569 TEST=http://www.espn.go.com/nba/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76608

Patch Set 1 #

Patch Set 2 : style #

Patch Set 3 : fix tests #

Patch Set 4 : "add TestGetDocumentURL #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -82 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/c/dev/ppb_url_util_dev.h	View		6 chunks	+25 lines, -20 lines	1 comment	Download
M	ppapi/cpp/dev/url_util_dev.h	View		1 chunk	+14 lines, -12 lines	0 comments	Download
M	ppapi/cpp/dev/url_util_dev.cc	View		2 chunks	+19 lines, -13 lines	0 comments	Download
M	ppapi/tests/test_url_util.h	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	ppapi/tests/test_url_util.cc	View	1 2 3	5 chunks	+24 lines, -12 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_util_impl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_url_util_impl.cc	View	1	7 chunks	+30 lines, -16 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

9 years, 9 months ago (2011-03-02 21:00:54 UTC) #2

LGTM.

http://codereview.chromium.org/6594107/diff/5001/ppapi/c/dev/ppb_url_util_dev.h
File ppapi/c/dev/ppb_url_util_dev.h (right):

http://codereview.chromium.org/6594107/diff/5001/ppapi/c/dev/ppb_url_util_dev...
ppapi/c/dev/ppb_url_util_dev.h:114: // window.location.href.
You should presumably say that |components| may be null.

http://codereview.chromium.org/6594107/diff/5001/webkit/plugins/ppapi/ppb_url...
File webkit/plugins/ppapi/ppb_url_util_impl.cc (right):

http://codereview.chromium.org/6594107/diff/5001/webkit/plugins/ppapi/ppb_url...
webkit/plugins/ppapi/ppb_url_util_impl.cc:173: return
GenerateURLReturn(instance->module(), frame->url(), components);
This looks okay to me, though I'm not the expert....

Expand Messages | Collapse Messages