Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 6594100: Sandbox the GPU process for Windows... (Closed)

Created:
9 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Sandbox the GPU process for Windows The policy is fairly restrictive token-wise but still the process needs access to the interactive desktop. Tweaks to the Job level in a different CL once it has baked in the dev channel. BUG=48607 TEST=see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76675

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -5 lines) Patch
M chrome/common/sandbox_policy.cc View 4 chunks +35 lines, -3 lines 0 comments Download
M chrome/gpu/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/gpu/gpu_main.cc View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/gpu/gpu_thread.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/gpu/gpu_thread.cc View 1 2 3 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
cpu_(ooo_6.6-7.5)
9 years, 9 months ago (2011-03-02 01:24:08 UTC) #1
apatrick_chromium
The check deps failures are obviously benign. Can you fix DEPS? I'm working remotely. Let's ...
9 years, 9 months ago (2011-03-02 18:52:35 UTC) #2
nsylvain
almost LGTM. i.e., just need to fix the trybots first;) http://codereview.chromium.org/6594100/diff/1005/chrome/gpu/gpu_thread.cc File chrome/gpu/gpu_thread.cc (right): http://codereview.chromium.org/6594100/diff/1005/chrome/gpu/gpu_thread.cc#newcode55 ...
9 years, 9 months ago (2011-03-02 19:07:35 UTC) #3
cpu_(ooo_6.6-7.5)
changes applied + deps update. please look again.
9 years, 9 months ago (2011-03-02 22:05:22 UTC) #4
nsylvain
LGTM
9 years, 9 months ago (2011-03-02 22:13:22 UTC) #5
apatrick_chromium
9 years, 9 months ago (2011-03-03 20:23:56 UTC) #6
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698