chrome/browser/ui/cocoa/file_metadata.mm - Issue 6594096: Clean up CF To NS Casts and make them slightly safer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/file_metadata.mm

Issue 6594096: Clean up CF To NS Casts and make them slightly safer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/file_metadata.mm

diff --git a/chrome/browser/ui/cocoa/file_metadata.mm b/chrome/browser/ui/cocoa/file_metadata.mm

index ca199a5937bd69b8eea27c22b190bb10138e097a..c069f09b6f43c16c36585244d1d26cba223b15da 100644

--- a/chrome/browser/ui/cocoa/file_metadata.mm

+++ b/chrome/browser/ui/cocoa/file_metadata.mm

@@ -70,7 +70,7 @@ void AddOriginMetadataToFile(const FilePath& file, const GURL& source,

return;

base::mac::ScopedCFTypeRef<MDItemRef> md_item(

- MDItemCreate(NULL, reinterpret_cast<CFStringRef>(file_path)));

+ MDItemCreate(NULL, base::mac::NSToCFCast(file_path)));

if (!md_item)

return;

@@ -88,7 +88,7 @@ void AddOriginMetadataToFile(const FilePath& file, const GURL& source,

[list addObject:referrer_url];

md_item_set_attribute_func(md_item, kMDItemWhereFroms,

- reinterpret_cast<CFArrayRef>(list));

+ base::mac::NSToCFCast(list));

}

// The OS will automatically quarantine files due to the