Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 6594096: Clean up CF To NS Casts and make them slightly safer (Closed)

Created:
9 years, 9 months ago by dmac
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Clean up CF To NS Casts and make them slightly safer Also adds streaming for CFStringRefs and CFErrorRefs making it easier to add them to LOG() type statements. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76714

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix up thakis comments #

Patch Set 3 : bad header path #

Total comments: 2

Patch Set 4 : fix space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -48 lines) Patch
M base/mac/mac_util.h View 1 1 chunk +59 lines, -40 lines 0 comments Download
M base/mac/mac_util.mm View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/install_from_dmg.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/keystone_glue.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/safari_importer.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/file_metadata.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/canvas_skia_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dmac
thakis, Mind taking a look if you get a chance? Just some old cleanup work ...
9 years, 9 months ago (2011-03-02 00:19:35 UTC) #1
Nico
Neat! http://codereview.chromium.org/6594096/diff/1/base/mac/mac_util.h File base/mac/mac_util.h (right): http://codereview.chromium.org/6594096/diff/1/base/mac/mac_util.h#newcode161 base/mac/mac_util.h:161: inline NSMutable##name* CFToNSCast(CFMutable##name##Ref cf_val) { \ I guess ...
9 years, 9 months ago (2011-03-02 02:21:22 UTC) #2
dmac
http://codereview.chromium.org/6594096/diff/1/base/mac/mac_util.h File base/mac/mac_util.h (right): http://codereview.chromium.org/6594096/diff/1/base/mac/mac_util.h#newcode161 base/mac/mac_util.h:161: inline NSMutable##name* CFToNSCast(CFMutable##name##Ref cf_val) { \ On 2011/03/02 02:21:22, ...
9 years, 9 months ago (2011-03-02 22:20:09 UTC) #3
Avi (use Gerrit)
http://codereview.chromium.org/6594096/diff/4009/base/mac/mac_util.mm File base/mac/mac_util.mm (right): http://codereview.chromium.org/6594096/diff/4009/base/mac/mac_util.mm#newcode483 base/mac/mac_util.mm:483: // Definitionsfor the corresponding CF_TO_NS_CAST_DECL macros in mac_util.h. drive ...
9 years, 9 months ago (2011-03-02 22:26:33 UTC) #4
dmac
nice catch avi. http://codereview.chromium.org/6594096/diff/4009/base/mac/mac_util.mm File base/mac/mac_util.mm (right): http://codereview.chromium.org/6594096/diff/4009/base/mac/mac_util.mm#newcode483 base/mac/mac_util.mm:483: // Definitionsfor the corresponding CF_TO_NS_CAST_DECL macros ...
9 years, 9 months ago (2011-03-02 22:29:02 UTC) #5
Nico
9 years, 9 months ago (2011-03-02 22:42:35 UTC) #6
LG

Powered by Google App Engine
This is Rietveld 408576698