Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: src/handles-inl.h

Issue 6594075: Remove HandleCell and use GlobalHandle and HandleScope::Escape instead. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32
Patch Set: Addressed review comment. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 45
46 template <typename T> 46 template <typename T>
47 inline T* Handle<T>::operator*() const { 47 inline T* Handle<T>::operator*() const {
48 ASSERT(location_ != NULL); 48 ASSERT(location_ != NULL);
49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue); 49 ASSERT(reinterpret_cast<Address>(*location_) != kHandleZapValue);
50 return *BitCast<T**>(location_); 50 return *BitCast<T**>(location_);
51 } 51 }
52 52
53 53
54 template <typename T>
55 HandleCell<T>::HandleCell(T* value)
56 : location_(HandleScope::CreateHandle(value)) { }
57
58
59 template <typename T>
60 HandleCell<T>::HandleCell(Handle<T> value)
61 : location_(HandleScope::CreateHandle(*value)) { }
62
63
64 #ifdef DEBUG 54 #ifdef DEBUG
65 inline NoHandleAllocation::NoHandleAllocation() { 55 inline NoHandleAllocation::NoHandleAllocation() {
66 v8::ImplementationUtilities::HandleScopeData* current = 56 v8::ImplementationUtilities::HandleScopeData* current =
67 v8::ImplementationUtilities::CurrentHandleScope(); 57 v8::ImplementationUtilities::CurrentHandleScope();
68 // Shrink the current handle scope to make it impossible to do 58 // Shrink the current handle scope to make it impossible to do
69 // handle allocations without an explicit handle scope. 59 // handle allocations without an explicit handle scope.
70 current->limit = current->next; 60 current->limit = current->next;
71 61
72 level_ = current->level; 62 level_ = current->level;
73 current->level = 0; 63 current->level = 0;
74 } 64 }
75 65
76 66
77 inline NoHandleAllocation::~NoHandleAllocation() { 67 inline NoHandleAllocation::~NoHandleAllocation() {
78 // Restore state in current handle scope to re-enable handle 68 // Restore state in current handle scope to re-enable handle
79 // allocations. 69 // allocations.
80 v8::ImplementationUtilities::HandleScopeData* current = 70 v8::ImplementationUtilities::HandleScopeData* current =
81 v8::ImplementationUtilities::CurrentHandleScope(); 71 v8::ImplementationUtilities::CurrentHandleScope();
82 ASSERT_EQ(0, current->level); 72 ASSERT_EQ(0, current->level);
83 current->level = level_; 73 current->level = level_;
84 } 74 }
85 #endif 75 #endif
86 76
87 77
88 } } // namespace v8::internal 78 } } // namespace v8::internal
89 79
90 #endif // V8_HANDLES_INL_H_ 80 #endif // V8_HANDLES_INL_H_
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698