Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 6594075: Remove HandleCell and use GlobalHandle and HandleScope::Escape instead. (Closed)

Created:
9 years, 9 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove HandleCell and use GlobalHandle and HandleScope::Escape instead. Added HandleScope::Escape to HandleScope to allow exiting a value from a scope. Committed: http://code.google.com/p/v8/source/detail?r=6993

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -79 lines) Patch
M src/handles.h View 1 4 chunks +37 lines, -60 lines 0 comments Download
M src/handles-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/runtime.cc View 1 4 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 9 months ago (2011-03-01 13:33:32 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/6594075/diff/1/src/handles.h File src/handles.h (right): http://codereview.chromium.org/6594075/diff/1/src/handles.h#newcode144 src/handles.h:144: Handle<T> Escape(Handle<T> handle_value) { I find the name ...
9 years, 9 months ago (2011-03-01 13:43:22 UTC) #2
Lasse Reichstein
9 years, 9 months ago (2011-03-01 14:02:32 UTC) #3
http://codereview.chromium.org/6594075/diff/1/src/handles.h
File src/handles.h (right):

http://codereview.chromium.org/6594075/diff/1/src/handles.h#newcode144
src/handles.h:144: Handle<T> Escape(Handle<T> handle_value) {
Done.

Powered by Google App Engine
This is Rietveld 408576698