Issue 6594073: Enable optimizing JSFunctions that are in new-space....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6594073: Enable optimizing JSFunctions that are in new-space.... (Closed)

Created:
9 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Karl Klose

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Enable optimizing JSFunctions that are in new-space. It avoids strange performance behavior where hot functions do not get optimized if there is no GC to promote them, and it does not seem to hurt us otherwise. Committed: http://code.google.com/p/v8/source/detail?r=7016

Patch Set 1 #

Patch Set 2 : Don't clear samples on GC #

Patch Set 3 : Fixed bug in GC #

Patch Set 4 : update samples at GC #

Patch Set 5 : '' #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -50 lines)			Patch
M	src/heap.cc	View	1 2 3	3 chunks	+3 lines, -10 lines	1 comment	Download
M	src/mark-compact.cc	View	1 2 3 4	3 chunks	+7 lines, -0 lines	0 comments	Download
M	src/runtime-profiler.h	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/runtime-profiler.cc	View	1 2 3 4	6 chunks	+33 lines, -38 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

fschneider

Please have another look. I removed the clearing of the sampler window and removed the ...

9 years, 9 months ago (2011-03-01 15:40:18 UTC) #3

Vyacheslav Egorov (Chromium)

GC part looks good to me. http://codereview.chromium.org/6594073/diff/6007/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6594073/diff/6007/src/heap.cc#newcode1072 src/heap.cc:1072: You can move ...

9 years, 9 months ago (2011-03-01 17:18:43 UTC) #5

Still LGTM.

Expand Messages | Collapse Messages