Issue 6594071: ARM: Support inlined version of %_FastAsciiArrayJoin on ARM

Issue 6594071: ARM: Support inlined version of %_FastAsciiArrayJoin on ARM (Closed)

Created:
9 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Support inlined version of %_FastAsciiArrayJoin on ARM Committed: http://code.google.com/p/v8/source/detail?r=6994

Patch Set 3 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+318 lines, -5 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2	1 chunk	+227 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1	1 chunk	+54 lines, -0 lines	0 comments	Download
M	test/mjsunit/array-join.js	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

This has been tested with unalignedaccesses=off. We already have have two variants of CopyBytes, which ...

9 years, 9 months ago (2011-03-01 13:12:58 UTC) #1

William Hesse

LGTM. http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#newcode3209 src/arm/full-codegen-arm.cc:3209: // We will leave the separator on the ...

9 years, 9 months ago (2011-03-01 13:54:11 UTC) #2

Søren Thygesen Gjesse

9 years, 9 months ago (2011-03-01 14:08:31 UTC) #3

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#...
src/arm/full-codegen-arm.cc:3209: // We will leave the separator on the stack
until the end of the function.
On 2011/03/01 13:54:11, William Hesse wrote:
> This comment seems inconsistent with the "pop separator" line below.

Done.

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#...
src/arm/full-codegen-arm.cc:3327: // Live values in registers:
On 2011/03/01 13:54:11, William Hesse wrote:
> array_length must be live here, because you use it below.

Done.

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#...
src/arm/full-codegen-arm.cc:3402: // labe long_separator below.
On 2011/03/01 13:54:11, William Hesse wrote:
> label

Done.

Expand Messages | Collapse Messages