lib/chromeos/load_firmware_fw.c - Issue 6594043: Fill-in more details of boot stub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/chromeos/load_firmware_fw.c

Issue 6594043: Fill-in more details of boot stub (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/u-boot-next.git@chromeos-v2010.09

Patch Set: Code review Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/chromeos/load_firmware_fw.c

diff --git a/lib/chromeos/load_firmware_fw.c b/lib/chromeos/load_firmware_fw.c

index 0eca2b96e35a80baeb6407a4341febfd2b727b17..2149ca161b58a3098678fdb2b752c26fa820ce5a 100644

--- a/lib/chromeos/load_firmware_fw.c

+++ b/lib/chromeos/load_firmware_fw.c

@@ -45,10 +45,8 @@ int GetFirmwareBody(LoadFirmwareParams *params, uint64_t index)

if (index == 0) {

block = params->verification_block_0;

- firmware_body = (uint8_t *) CONFIG_FIRMWARE_BODY_BUFFER_0;

Che-Liang Chiou 2011/03/01 08:45:22 Changes due to earlier code review comments. Remov

} else {

block = params->verification_block_1;

- firmware_body = (uint8_t *) CONFIG_FIRMWARE_BODY_BUFFER_1;

}

data_offset = ci->firmware_data_offset[index];

ci->firmware_body[index] = malloc(MAX(CONFIG_LENGTH_FW_A_DATA,

« common/cmd_cros_bootstub.c ('K') | « common/cmd_cros_bootstub.c ('k') | no next file » | no next file with comments »