Issue 6594038: Accept output from even more Git versions in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6594038: Accept output from even more Git versions in tests. (Closed)

Created:
9 years, 9 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, evanm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Accept output from even more Git versions in tests. BUG=none TEST=none

Patch Set 2 : whitespace #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -15 lines)			Patch
	M	tests/gclient_scm_test.py	View		2 chunks	+11 lines, -15 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

evanm

http://codereview.chromium.org/6594038/diff/1001/tests/gclient_scm_test.py File tests/gclient_scm_test.py (right): http://codereview.chromium.org/6594038/diff/1001/tests/gclient_scm_test.py#newcode755 tests/gclient_scm_test.py:755: self.assertTrue(re.match(msg_re, out)) Might be better to just set the ...

9 years, 9 months ago (2011-02-28 22:35:11 UTC) #1

Bernhard Bauer

On Mon, Feb 28, 2011 at 23:35, <evanm@google.com> wrote: > > http://codereview.chromium.org/6594038/diff/1001/tests/gclient_scm_test.py > File tests/gclient_scm_test.py ...

9 years, 9 months ago (2011-02-28 22:46:17 UTC) #2

Agreed. I didn't write that test.

Expand Messages | Collapse Messages

Issue 6594038: Accept output from even more Git versions in tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : whitespace #

Messages