Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 6594037: Strict Mode assignment to read only property. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: CR Feedback. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/virtual-frame-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2390 matching lines...) Expand 10 before | Expand all | Expand 10 after
2401 } 2401 }
2402 2402
2403 // Stub never generated for non-global objects that require access 2403 // Stub never generated for non-global objects that require access
2404 // checks. 2404 // checks.
2405 ASSERT(receiver->IsJSGlobalProxy() || !receiver->IsAccessCheckNeeded()); 2405 ASSERT(receiver->IsJSGlobalProxy() || !receiver->IsAccessCheckNeeded());
2406 2406
2407 __ pop(rbx); // remove the return address 2407 __ pop(rbx); // remove the return address
2408 __ push(rdx); // receiver 2408 __ push(rdx); // receiver
2409 __ push(rcx); // name 2409 __ push(rcx); // name
2410 __ push(rax); // value 2410 __ push(rax); // value
2411 __ Push(Smi::FromInt(strict_mode_));
2411 __ push(rbx); // restore return address 2412 __ push(rbx); // restore return address
2412 2413
2413 // Do tail-call to the runtime system. 2414 // Do tail-call to the runtime system.
2414 ExternalReference store_ic_property = 2415 ExternalReference store_ic_property =
2415 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty)); 2416 ExternalReference(IC_Utility(IC::kStoreInterceptorProperty));
2416 __ TailCallExternalReference(store_ic_property, 3, 1); 2417 __ TailCallExternalReference(store_ic_property, 4, 1);
2417 2418
2418 // Handle store cache miss. 2419 // Handle store cache miss.
2419 __ bind(&miss); 2420 __ bind(&miss);
2420 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss)); 2421 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Miss));
2421 __ Jump(ic, RelocInfo::CODE_TARGET); 2422 __ Jump(ic, RelocInfo::CODE_TARGET);
2422 2423
2423 // Return the generated code. 2424 // Return the generated code.
2424 return GetCode(INTERCEPTOR, name); 2425 return GetCode(INTERCEPTOR, name);
2425 } 2426 }
2426 2427
(...skipping 1056 matching lines...) Expand 10 before | Expand all | Expand 10 after
3483 // -- rax : value 3484 // -- rax : value
3484 // -- rcx : key 3485 // -- rcx : key
3485 // -- rdx : receiver 3486 // -- rdx : receiver
3486 // -- rsp[0] : return address 3487 // -- rsp[0] : return address
3487 // ----------------------------------- 3488 // -----------------------------------
3488 3489
3489 __ pop(rbx); 3490 __ pop(rbx);
3490 __ push(rdx); // receiver 3491 __ push(rdx); // receiver
3491 __ push(rcx); // key 3492 __ push(rcx); // key
3492 __ push(rax); // value 3493 __ push(rax); // value
3494 __ Push(Smi::FromInt(NONE)); // PropertyAttributes
3495 __ Push(Smi::FromInt(
3496 Code::ExtractExtraICStateFromFlags(flags) & kStrictMode));
3493 __ push(rbx); // return address 3497 __ push(rbx); // return address
3494 3498
3495 // Do tail-call to runtime routine. 3499 // Do tail-call to runtime routine.
3496 __ TailCallRuntime(Runtime::kSetProperty, 3, 1); 3500 __ TailCallRuntime(Runtime::kSetProperty, 5, 1);
3497 3501
3498 return GetCode(flags); 3502 return GetCode(flags);
3499 } 3503 }
3500 3504
3501 #undef __ 3505 #undef __
3502 3506
3503 } } // namespace v8::internal 3507 } } // namespace v8::internal
3504 3508
3505 #endif // V8_TARGET_ARCH_X64 3509 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/virtual-frame-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698