Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: src/debug.cc

Issue 6594037: Strict Mode assignment to read only property. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: CR Feedback. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.cc ('k') | src/handles.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 818 matching lines...) Expand 10 before | Expand all | Expand 10 after
829 NULL); 829 NULL);
830 830
831 // Use the debugger context. 831 // Use the debugger context.
832 SaveContext save; 832 SaveContext save;
833 Top::set_context(*context); 833 Top::set_context(*context);
834 834
835 // Expose the builtins object in the debugger context. 835 // Expose the builtins object in the debugger context.
836 Handle<String> key = Factory::LookupAsciiSymbol("builtins"); 836 Handle<String> key = Factory::LookupAsciiSymbol("builtins");
837 Handle<GlobalObject> global = Handle<GlobalObject>(context->global()); 837 Handle<GlobalObject> global = Handle<GlobalObject>(context->global());
838 RETURN_IF_EMPTY_HANDLE_VALUE( 838 RETURN_IF_EMPTY_HANDLE_VALUE(
839 SetProperty(global, key, Handle<Object>(global->builtins()), NONE), 839 SetProperty(global, key, Handle<Object>(global->builtins()),
840 NONE, kNonStrictMode),
840 false); 841 false);
841 842
842 // Compile the JavaScript for the debugger in the debugger context. 843 // Compile the JavaScript for the debugger in the debugger context.
843 Debugger::set_compiling_natives(true); 844 Debugger::set_compiling_natives(true);
844 bool caught_exception = 845 bool caught_exception =
845 !CompileDebuggerScript(Natives::GetIndex("mirror")) || 846 !CompileDebuggerScript(Natives::GetIndex("mirror")) ||
846 !CompileDebuggerScript(Natives::GetIndex("debug")); 847 !CompileDebuggerScript(Natives::GetIndex("debug"));
847 848
848 if (FLAG_enable_liveedit) { 849 if (FLAG_enable_liveedit) {
849 caught_exception = caught_exception || 850 caught_exception = caught_exception ||
(...skipping 2225 matching lines...) Expand 10 before | Expand all | Expand 10 after
3075 { 3076 {
3076 Locker locker; 3077 Locker locker;
3077 Debugger::CallMessageDispatchHandler(); 3078 Debugger::CallMessageDispatchHandler();
3078 } 3079 }
3079 } 3080 }
3080 } 3081 }
3081 3082
3082 #endif // ENABLE_DEBUGGER_SUPPORT 3083 #endif // ENABLE_DEBUGGER_SUPPORT
3083 3084
3084 } } // namespace v8::internal 3085 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698