Strict Mode assignment to read only property.

src/builtins.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 118 matching lines @@
                                 Code::kNoExtraICState)                    \
   V(StoreIC_ArrayLength,        STORE_IC, MONOMORPHIC,                    \
                                 Code::kNoExtraICState)                    \
   V(StoreIC_Normal,             STORE_IC, MONOMORPHIC,                    \
                                 Code::kNoExtraICState)                    \
   V(StoreIC_Megamorphic,        STORE_IC, MEGAMORPHIC,                    \
                                 Code::kNoExtraICState)                    \
   V(StoreIC_GlobalProxy,        STORE_IC, MEGAMORPHIC,                    \
                                 Code::kNoExtraICState)                    \
   V(StoreIC_Initialize_Strict,  STORE_IC, UNINITIALIZED,                  \
-                                StoreIC::kStoreICStrict)                  \

[Martin Maly, 2011/02/27 23:04:04]

I deleted this enum in favor of using StrictModeFlag directly. It is way
cleaner.

+                                kStrictMode)                              \
   V(StoreIC_ArrayLength_Strict, STORE_IC, MONOMORPHIC,                    \
-                                StoreIC::kStoreICStrict)                  \
+                                kStrictMode)                              \
   V(StoreIC_Normal_Strict,      STORE_IC, MONOMORPHIC,                    \
-                                StoreIC::kStoreICStrict)                  \
+                                kStrictMode)                              \
   V(StoreIC_Megamorphic_Strict, STORE_IC, MEGAMORPHIC,                    \
-                                StoreIC::kStoreICStrict)                  \
+                                kStrictMode)                              \
   V(StoreIC_GlobalProxy_Strict, STORE_IC, MEGAMORPHIC,                    \
-                                StoreIC::kStoreICStrict)                  \
+                                kStrictMode)                              \
                                                                           \
   V(KeyedStoreIC_Initialize,    KEYED_STORE_IC, UNINITIALIZED,            \
                                 Code::kNoExtraICState)                    \
   V(KeyedStoreIC_Generic,       KEYED_STORE_IC, MEGAMORPHIC,              \
                                 Code::kNoExtraICState)                    \
                                                                           \
+  V(KeyedStoreIC_Initialize_Strict,   KEYED_STORE_IC, UNINITIALIZED,      \

[Mads Ager (chromium), 2011/02/28 12:23:06]

This is the reason why I don't like indentation like this. Either we should
indent them all so they align or we should drop the alignment altogether. 

[Martin Maly, 2011/03/01 01:40:29]

Done.

+                                kStrictMode)                              \
+  V(KeyedStoreIC_Generic_Strict,      KEYED_STORE_IC, MEGAMORPHIC,        \
+                                kStrictMode)                              \
+                                                                          \
   /* Uses KeyedLoadIC_Initialize; must be after in list. */               \
   V(FunctionCall,               BUILTIN, UNINITIALIZED,                   \
                                 Code::kNoExtraICState)                    \
   V(FunctionApply,              BUILTIN, UNINITIALIZED,                   \
                                 Code::kNoExtraICState)                    \
                                                                           \
   V(ArrayCode,                  BUILTIN, UNINITIALIZED,                   \
                                 Code::kNoExtraICState)                    \
   V(ArrayConstructCode,         BUILTIN, UNINITIALIZED,                   \
                                 Code::kNoExtraICState)                    \
@@ skipping 161 matching lines @@
   static void Generate_ArrayConstructCode(MacroAssembler* masm);
 
   static void Generate_StringConstructCode(MacroAssembler* masm);
 
   static void Generate_OnStackReplacement(MacroAssembler* masm);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_BUILTINS_H_