Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 6592087: Until we have sparse histograms, to track error codes, we are using... (Closed)

Created:
9 years, 9 months ago by ramant (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Until we have sparse histograms, to track error codes, we are using UMA_HISTOGRAM_ENUMERATION and specify 16000 as the bucket size. Bumped up kBucketCount_MAX to 2**16. BUG=74618 TEST=We need to test MemoryMappedFile on windows in the browser to send histogram data for MemoryMappedFile.CreateFileMapping. R=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76514

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/metrics/histogram.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
Hi Jim, Small change to bump the max bucket size for histograms. thanks, raman
9 years, 9 months ago (2011-03-02 00:06:19 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 9 months ago (2011-03-02 03:01:36 UTC) #2
jar (doing other things)
9 years, 9 months ago (2011-03-02 06:15:40 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698