Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 6592071: Pepper/Flapper: Add an interface to do sync file ops on FileRefs. (Closed)

Created:
9 years, 9 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Pepper/Flapper: Add an interface to do sync file ops on FileRefs. Such FileRefs are typically obtained from the Pepper file chooser. The interface corresponds exactly to the one for module-local files. (The implementation is only enabled if Flapper hacks are enabled.) BUG=none TEST=Flapper file uploads work for me Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76446

Patch Set 1 #

Patch Set 2 : make upload progress work #

Total comments: 1

Patch Set 3 : changes per piman #

Patch Set 4 : oops, forgot one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -56 lines) Patch
M chrome/common/pepper_file_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.cc View 9 chunks +58 lines, -33 lines 0 comments Download
M ppapi/c/private/ppb_flash_file.h View 2 chunks +45 lines, -19 lines 0 comments Download
M webkit/plugins/ppapi/file_path.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/file_path.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_file_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_file_impl.cc View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
9 years, 9 months ago (2011-03-01 18:03:01 UTC) #1
piman
LGTM. Don't forget the proxy. http://codereview.chromium.org/6592071/diff/3001/webkit/plugins/ppapi/ppb_flash_file_impl.cc File webkit/plugins/ppapi/ppb_flash_file_impl.cc (right): http://codereview.chromium.org/6592071/diff/3001/webkit/plugins/ppapi/ppb_flash_file_impl.cc#newcode255 webkit/plugins/ppapi/ppb_flash_file_impl.cc:255: PP_Resource to_file_ref_id) { I'm ...
9 years, 9 months ago (2011-03-01 21:54:29 UTC) #2
viettrungluu
Thanks. I'll do the proxy in a separate CL. On 2011/03/01 21:54:29, piman wrote: > ...
9 years, 9 months ago (2011-03-01 22:18:20 UTC) #3
piman
9 years, 9 months ago (2011-03-01 23:03:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698