Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 6592064: Make the materialization of smi constants consistent between the two compiler... (Closed)

Created:
9 years, 9 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the materialization of smi constants consistent between the two compilers. This change makes the full code generator always materialize smi constants to match the behavior of the environment tracked in the optimizing compiler. The mismatch between environment and what the non-optimized code causes problems and potentially crashes when doing deoptimization and OSR. BUG=67732 Committed: http://code.google.com/p/v8/source/detail?r=6982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -547 lines) Patch
M src/arm/full-codegen-arm.cc View 4 chunks +4 lines, -234 lines 0 comments Download
M src/full-codegen.h View 3 chunks +1 line, -39 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +4 lines, -16 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +4 lines, -237 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 9 months ago (2011-03-01 10:39:22 UTC) #1
Kevin Millikin (Chromium)
9 years, 9 months ago (2011-03-01 10:42:27 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698