Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 6592038: X64 Crankshaft: Add DoPower to lithium compiler on x64 platform. (Closed)

Created:
9 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

X64 Crankshaft: Add DoPower to lithium compiler on x64 platform. Committed: http://code.google.com/p/v8/source/detail?r=6980

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -3 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +48 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
9 years, 9 months ago (2011-02-28 16:39:57 UTC) #1
Rico
LGTM http://codereview.chromium.org/6592038/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6592038/diff/1/src/x64/lithium-codegen-x64.cc#newcode2466 src/x64/lithium-codegen-x64.cc:2466: DoubleRegister left_reg = ToDoubleRegister(left); I don't think we ...
9 years, 9 months ago (2011-02-28 19:18:34 UTC) #2
William Hesse
9 years, 9 months ago (2011-03-01 09:30:45 UTC) #3
Comments all addressed.  Added Win64 use of rdx instead of rdi for first integer
argument.

Powered by Google App Engine
This is Rietveld 408576698