Issue 6592019: libmetrics: Support partial writes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6592019: libmetrics: Support partial writes. (Closed)

Created:
9 years, 10 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/metrics.git@master

Visibility:
Public.

Description

libmetrics: Support partial writes. BUG=chromium-os:11125 TEST=unit tests, tested on device Change-Id: If9066988b86f61cb5bae413b7250d5426854f31b Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ddfc9e1

Patch Set 1 #

Total comments: 1

Patch Set 2 : use "" #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	metrics_library.cc	View	1	3 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

9 years, 10 months ago (2011-02-25 21:38:34 UTC) #2

LGTM

http://codereview.chromium.org/6592019/diff/1/metrics_library.cc
File metrics_library.cc (right):

http://codereview.chromium.org/6592019/diff/1/metrics_library.cc#newcode15
metrics_library.cc:15: #include <base/eintr_wrapper.h>  // HANDLE_EINTR macro,
no libbase required.
nit: i think the usual style is to use double quotes around non-system headers;
see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

Expand Messages | Collapse Messages