Issue 6592013: Modified build_image to support new crossdev.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6592013: Modified build_image to support new crossdev. (Closed)

Created:
9 years, 10 months ago by raymes

Modified:
9 years, 7 months ago

Reviewers:
davidjames, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Modified build_image to support new crossdev. BUG=none TEST=Ran build_image with and without the crossdev upgrade. Made sure it was picking up the correct tarball. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9e1084c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	build_image	View	1	2 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

davidjames

LGTM w/nits http://codereview.chromium.org/6592013/diff/1/build_image File build_image (right): http://codereview.chromium.org/6592013/diff/1/build_image#newcode265 build_image:265: LIBC_VERSION=${LIBC_VERSION:-"2.10.1-r2"} So it looks like LIBC_VERSION has ...

9 years, 10 months ago (2011-02-25 19:22:18 UTC) #2

raymes

9 years, 10 months ago (2011-02-25 19:35:22 UTC) #3

On 2011/02/25 19:22:18, davidjames wrote:
> LGTM w/nits
> 
> http://codereview.chromium.org/6592013/diff/1/build_image
> File build_image (right):
> 
> http://codereview.chromium.org/6592013/diff/1/build_image#newcode265
> build_image:265: LIBC_VERSION=${LIBC_VERSION:-"2.10.1-r2"}
> So it looks like LIBC_VERSION has been in
> ${BOARD_ROOT}/etc/make.conf.board_setup since Feb 10, 2010. If someone has a
> board older than that, they probably won't have version 2.10.1-r2 (or even
> 2.10.1-r1) of binutils yet. Maybe time to delete this backwards compatibility
> hack?
Agreed. They would have been caught by this already if it was being used.
Removed.

> 
> http://codereview.chromium.org/6592013/diff/1/build_image#newcode605
> build_image:605: # backward compatibility with the crossdev location change
> Please add a trailing period.
Done.

Will commit.

Expand Messages | Collapse Messages