Issue 6592010: Minor change to FullCodeGenerator::EmitFastAsciiArrayJoin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6592010: Minor change to FullCodeGenerator::EmitFastAsciiArrayJoin... (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Minor change to FullCodeGenerator::EmitFastAsciiArrayJoin The counting loop is always run at least once, and checking the loop condition once is sufficient. Committed: http://code.google.com/p/v8/source/detail?r=6979

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/ia32/full-codegen-ia32.cc	View	1	4 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

9 years, 10 months ago (2011-02-25 13:55:49 UTC) #3

LGTM, once the unused loop_condition label is removed.
Also, the assert comment could be clearer.

Expand Messages | Collapse Messages