Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: views/events/event_gtk.cc

Issue 6591120: Update MouseEvent (initial pass). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup more MouseEvent related code. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/events/event.h" 5 #include "views/events/event.h"
6 6
7 #include <gdk/gdk.h> 7 #include <gdk/gdk.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "ui/base/keycodes/keyboard_code_conversion_gtk.h" 10 #include "ui/base/keycodes/keyboard_code_conversion_gtk.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 LocatedEvent::LocatedEvent(NativeEvent2 native_event_2, 147 LocatedEvent::LocatedEvent(NativeEvent2 native_event_2,
148 FromNativeEvent2 from_native) 148 FromNativeEvent2 from_native)
149 : Event(native_event_2, ui::ET_UNKNOWN, 0, from_native) { 149 : Event(native_event_2, ui::ET_UNKNOWN, 0, from_native) {
150 // No one should ever call this on Gtk-views. 150 // No one should ever call this on Gtk-views.
151 // TODO(msw): remove once we rid views of Gtk/Gdk. 151 // TODO(msw): remove once we rid views of Gtk/Gdk.
152 NOTREACHED(); 152 NOTREACHED();
153 } 153 }
154 #endif 154 #endif
155 155
156 //////////////////////////////////////////////////////////////////////////////// 156 ////////////////////////////////////////////////////////////////////////////////
157 // MouseEvent, public:
158
159 MouseEvent::MouseEvent(NativeEvent native_event)
160 : LocatedEvent(native_event) {
161 }
162
163 MouseEvent::MouseEvent(NativeEvent2 native_event_2,
164 FromNativeEvent2 from_native)
Ben Goodger (Google) 2011/03/07 22:08:42 I think you need a #if !defined(TOUCH_UI) around t
msw 2011/03/07 23:57:21 Done.
165 : LocatedEvent(native_event_2, from_native) {
166 // No one should ever call this on Gtk-views.
167 // TODO(msw): remove once we rid views of Gtk/Gdk.
168 NOTREACHED();
169 }
170
171 ////////////////////////////////////////////////////////////////////////////////
157 // KeyEvent, public: 172 // KeyEvent, public:
158 173
159 KeyEvent::KeyEvent(NativeEvent native_event) 174 KeyEvent::KeyEvent(NativeEvent native_event)
160 : Event(native_event, EventTypeFromNative(native_event), 175 : Event(native_event, EventTypeFromNative(native_event),
161 GetFlagsFromGdkState(GetGdkStateFromNative(native_event))), 176 GetFlagsFromGdkState(GetGdkStateFromNative(native_event))),
162 key_code_(ui::WindowsKeyCodeForGdkKeyCode( 177 key_code_(ui::WindowsKeyCodeForGdkKeyCode(
163 GetGdkEventKeyFromNative(native_event)->keyval)) { 178 GetGdkEventKeyFromNative(native_event)->keyval)) {
164 } 179 }
165 180
166 #if !defined(TOUCH_UI) 181 #if !defined(TOUCH_UI)
167 KeyEvent::KeyEvent(NativeEvent2 native_event_2, FromNativeEvent2 from_native) 182 KeyEvent::KeyEvent(NativeEvent2 native_event_2, FromNativeEvent2 from_native)
168 : Event(native_event_2, ui::ET_UNKNOWN, 0, from_native) { 183 : Event(native_event_2, ui::ET_UNKNOWN, 0, from_native) {
169 // No one should ever call this on Gtk-views. 184 // No one should ever call this on Gtk-views.
170 // TODO(beng): remove once we rid views of Gtk/Gdk. 185 // TODO(beng): remove once we rid views of Gtk/Gdk.
171 NOTREACHED(); 186 NOTREACHED();
172 } 187 }
173 #endif 188 #endif
174 189
175 //////////////////////////////////////////////////////////////////////////////// 190 ////////////////////////////////////////////////////////////////////////////////
176 // MouseWheelEvent, public: 191 // MouseWheelEvent, public:
177 192
178 MouseWheelEvent::MouseWheelEvent(NativeEvent native_event) 193 MouseWheelEvent::MouseWheelEvent(NativeEvent native_event)
179 : LocatedEvent(native_event), 194 : MouseEvent(native_event),
180 offset_(GetMouseWheelOffset(native_event)) { 195 offset_(GetMouseWheelOffset(native_event)) {
181 } 196 }
182 197
183 #if !defined(TOUCH_UI) 198 #if !defined(TOUCH_UI)
184 MouseWheelEvent::MouseWheelEvent(NativeEvent2 native_event_2, 199 MouseWheelEvent::MouseWheelEvent(NativeEvent2 native_event_2,
185 FromNativeEvent2 from_native) 200 FromNativeEvent2 from_native)
186 : LocatedEvent(native_event_2, from_native) { 201 : MouseEvent(native_event_2, from_native) {
187 // No one should ever call this on Gtk-views. 202 // No one should ever call this on Gtk-views.
188 // TODO(msw): remove once we rid views of Gtk/Gdk. 203 // TODO(msw): remove once we rid views of Gtk/Gdk.
189 NOTREACHED(); 204 NOTREACHED();
190 } 205 }
191 #endif 206 #endif
192 207
193 } // namespace views 208 } // namespace views
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698