Implement the grab/grabbing cursors (for Mac/GTK)....

Implement the grab/grabbing cursors (for Mac/GTK).

BUG=73356
TEST=comment 12 on the bug has a test page; ensure the last two cursors (grab and grabbing) show open and closed hand cursors (respectively) and don't crash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76616

[Avi (use Gerrit), 2011-03-02 16:26:12]

Evan: GTK stuff
VTL: Mac stuff + Pepper stuff

[Avi (use Gerrit), 2011-03-02 16:28:12]

On 2011/03/02 16:26:12, Avi wrote:
> Evan: GTK stuff
> VTL: Mac stuff + Pepper stuff

Someone also take a look at the _win file.

[evanm, 2011-03-02 16:35:57]

http://codereview.chromium.org/6591105/diff/1/webkit/glue/webcursor_gtk_data.h
File webkit/glue/webcursor_gtk_data.h (right):

http://codereview.chromium.org/6591105/diff/1/webkit/glue/webcursor_gtk_data....
webkit/glue/webcursor_gtk_data.h:315: } ;
not your fault, but needless space here

http://codereview.chromium.org/6591105/diff/1/webkit/glue/webcursor_gtk_data....
webkit/glue/webcursor_gtk_data.h:333: { "dnd-no-drop", moz_not_allowed_bits,
moz_not_allowed_mask_bits, 9,  9 },
Do we use this one or the one below?

[Avi (use Gerrit), 2011-03-02 16:42:48]

http://codereview.chromium.org/6591105/diff/1/webkit/glue/webcursor_gtk_data.h
File webkit/glue/webcursor_gtk_data.h (right):

http://codereview.chromium.org/6591105/diff/1/webkit/glue/webcursor_gtk_data....
webkit/glue/webcursor_gtk_data.h:315: } ;
On 2011/03/02 16:35:57, evanm wrote:
> not your fault, but needless space here

Done.

http://codereview.chromium.org/6591105/diff/1/webkit/glue/webcursor_gtk_data....
webkit/glue/webcursor_gtk_data.h:333: { "dnd-no-drop", moz_not_allowed_bits,
moz_not_allowed_mask_bits, 9,  9 },
On 2011/03/02 16:35:57, evanm wrote:
> Do we use this one or the one below?

No.

I was updating in bulk, and there was a gap between cursors we used. Sounds like
you'd prefer if we didn't have those cursors.

Done.

[evanm, 2011-03-02 16:57:46]

Linux bits LGTM
(I just worried that the extra data wouldn't be eliminated by the compiler)

[viettrungluu, 2011-03-02 21:10:09]

lgtm

http://codereview.chromium.org/6591105/diff/4004/webkit/glue/webcursor_win.cc
File webkit/glue/webcursor_win.cc (right):

http://codereview.chromium.org/6591105/diff/4004/webkit/glue/webcursor_win.cc...
webkit/glue/webcursor_win.cc:103: return IDC_ARROW;
Maybe a NOTIMPLEMENTED(), so we don't forget?

[Avi (use Gerrit), 2011-03-02 21:11:35]

http://codereview.chromium.org/6591105/diff/4004/webkit/glue/webcursor_win.cc
File webkit/glue/webcursor_win.cc (right):

http://codereview.chromium.org/6591105/diff/4004/webkit/glue/webcursor_win.cc...
webkit/glue/webcursor_win.cc:103: return IDC_ARROW;
On 2011/03/02 21:10:10, viettrungluu wrote:
> Maybe a NOTIMPLEMENTED(), so we don't forget?

This is a valid code path that can be triggered by user input. Don't want to
spew in the log.